From 485204b4fadb3f70d0f3835a572c1e53fa6a8268 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Fri, 7 Feb 2025 15:24:50 +0100 Subject: [PATCH] winbindd: wbint_bh_raw_call_child_done() doesn't have state->domain Only child or domain binding handles are possible! Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme --- source3/winbindd/winbindd_dual_ndr.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/source3/winbindd/winbindd_dual_ndr.c b/source3/winbindd/winbindd_dual_ndr.c index 0b44dbedb08..219596b9fc0 100644 --- a/source3/winbindd/winbindd_dual_ndr.c +++ b/source3/winbindd/winbindd_dual_ndr.c @@ -176,11 +176,6 @@ static void wbint_bh_raw_call_child_done(struct tevent_req *subreq) return; } - if (state->domain != NULL) { - wcache_store_ndr(state->domain, state->opnum, - &state->in_data, &state->out_data); - } - tevent_req_done(req); } @@ -523,6 +518,9 @@ struct dcerpc_binding_handle *wbint_binding_handle(TALLOC_CTX *mem_ctx, struct dcerpc_binding *b = NULL; NTSTATUS status; + SMB_ASSERT((domain != NULL && child == NULL) || + (domain == NULL && child != NULL)); + h = dcerpc_binding_handle_create(mem_ctx, &wbint_bh_ops, NULL, -- 2.47.3