From 4859071fd0efc6e962c0941810ab614cb54157b1 Mon Sep 17 00:00:00 2001 From: Giovanni Bechis Date: Wed, 5 Apr 2023 09:05:24 +0000 Subject: [PATCH] log an error when ap_runtime_dir_relative fails. spotted by rpluem@ git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1908984 13f79535-47bb-0310-9956-ffa450edef68 --- docs/log-message-tags/next-number | 2 +- modules/generators/mod_cgid.c | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/log-message-tags/next-number b/docs/log-message-tags/next-number index 021188b7975..a37a802aea9 100644 --- a/docs/log-message-tags/next-number +++ b/docs/log-message-tags/next-number @@ -1 +1 @@ -10423 +10424 diff --git a/modules/generators/mod_cgid.c b/modules/generators/mod_cgid.c index de3e4b353ae..6886ec39f04 100644 --- a/modules/generators/mod_cgid.c +++ b/modules/generators/mod_cgid.c @@ -1059,8 +1059,11 @@ static int cgid_init(apr_pool_t *p, apr_pool_t *plog, apr_pool_t *ptemp, parent_pid = getpid(); tmp_sockname = ap_runtime_dir_relative(p, sockname); - if (!tmp_sockname) + if (!tmp_sockname) { + ap_log_error(APLOG_MARK, APLOG_ERR, 0, main_server, APLOGNO(10423) + "Invalid socket path %s", sockname); return DECLINED; + } if (strlen(tmp_sockname) > sizeof(server_addr->sun_path) - 1) { tmp_sockname[sizeof(server_addr->sun_path)] = '\0'; ap_log_error(APLOG_MARK, APLOG_ERR, 0, main_server, APLOGNO(01254) -- 2.47.3