From 4961ad0c63849d360edf7c23a15001ff56d58639 Mon Sep 17 00:00:00 2001 From: GeoSot Date: Thu, 10 Jun 2021 01:10:14 +0300 Subject: [PATCH] Remove redundant check on `data-toggle` click. Previously, it was assumed that the trigger element would have its own separate config than the collapse element itself. --- js/src/collapse.js | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/js/src/collapse.js b/js/src/collapse.js index a8651fc0a9..fcb8be6d7d 100644 --- a/js/src/collapse.js +++ b/js/src/collapse.js @@ -347,26 +347,16 @@ EventHandler.on(document, EVENT_CLICK_DATA_API, SELECTOR_DATA_TOGGLE, function ( event.preventDefault() } - const triggerData = Manipulator.getDataAttributes(this) const selector = getSelectorFromElement(this) const selectorElements = SelectorEngine.find(selector) selectorElements.forEach(element => { const data = Collapse.getInstance(element) - let config if (data) { - // update parent attribute - if (data._parent === null && typeof triggerData.parent === 'string') { - data._config.parent = triggerData.parent - data._parent = data._getParent() - } - - config = 'toggle' + data.toggle() } else { - config = triggerData + Collapse.getOrCreateInstance(element) } - - Collapse.collapseInterface(element, config) }) }) -- 2.47.3