From 4c04960ba0603ff64bd70198e0022948a6df1f62 Mon Sep 17 00:00:00 2001 From: Leo-Andres Hofmann Date: Wed, 6 Apr 2022 15:46:52 +0200 Subject: [PATCH] getrrdimage.cgi: Add default values to parameters MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Prevents "use of uninitialized value" warnings when the CGI is called with broken undefined GET parameters. Signed-off-by: Leo-Andres Hofmann Reviewed-by: Peter Müller --- html/cgi-bin/getrrdimage.cgi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/html/cgi-bin/getrrdimage.cgi b/html/cgi-bin/getrrdimage.cgi index 26e026bba9..6ec91cc926 100644 --- a/html/cgi-bin/getrrdimage.cgi +++ b/html/cgi-bin/getrrdimage.cgi @@ -44,9 +44,9 @@ my @supported_origins = ("entropy.cgi", "hardwaregraphs.cgi", "media.cgi", my $uri = URI->new($ENV{'REQUEST_URI'}); my %query = $uri->query_form; -my $origin = lc $query{'origin'}; # lower case -my $graph = $query{'graph'}; -my $range = lc $query{'range'}; # lower case +my $origin = lc ($query{'origin'} // ''); # lower case +my $graph = $query{'graph'} // ''; +my $range = lc ($query{'range'} // ''); # lower case # Check parameters unless(($origin =~ /^\w+?\.cgi$/) && ($graph =~ /^[\w\-.,; ]+?$/) && ($range ~~ @Graphs::time_ranges)) { -- 2.39.5