From 4c1646e23f761e3dc6d88c8995f13be8f668a012 Mon Sep 17 00:00:00 2001 From: "AlanoSong@163.com" Date: Tue, 25 Nov 2025 21:19:55 +0800 Subject: [PATCH] ui/vnc: Fix qemu abort when query vnc info MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit When there is no display device on qemu machine, and user only access qemu by remote vnc. At the same time user input `info vnc` by QMP, the qemu will abort. To avoid the abort above, I add display device check, when query vnc info in qmp_query_vnc_servers(). Reviewed-by: Marc-AndréLureau Signed-off-by: Alano Song [ Marc-André - removed useless Error *err ] Signed-off-by: Marc-André Lureau Message-ID: <20251125131955.7024-1-AlanoSong@163.com> --- ui/vnc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 0d499b208b..e6bcf0e1cf 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -556,9 +556,12 @@ VncInfo2List *qmp_query_vnc_servers(Error **errp) qmp_query_auth(vd->auth, vd->subauth, &info->auth, &info->vencrypt, &info->has_vencrypt); if (vd->dcl.con) { - dev = DEVICE(object_property_get_link(OBJECT(vd->dcl.con), - "device", &error_abort)); - info->display = g_strdup(dev->id); + Object *obj = object_property_get_link(OBJECT(vd->dcl.con), + "device", NULL); + if (obj) { + dev = DEVICE(obj); + info->display = g_strdup(dev->id); + } } if (vd->listener != NULL) { nsioc = qio_net_listener_nsioc(vd->listener); -- 2.47.3