From 4ce1bd6e3783eef817ffd265616a2e6aa4cca2a3 Mon Sep 17 00:00:00 2001 From: Pavel Hrdina Date: Mon, 22 Sep 2014 18:19:07 +0200 Subject: [PATCH] domain_conf: fix domain deadlock If you use public api virConnectListAllDomains() with second parameter set to NULL to get only the number of domains you will lock out all other operations with domains. Introduced by commit 2c680804. Signed-off-by: Pavel Hrdina (cherry picked from commit fc22b2e74890873848b43fffae43025d22053669) --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 1d5cc14390..a65f4e31f5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19112,7 +19112,7 @@ virDomainListPopulate(void *payload, /* just count the machines */ if (!data->domains) { data->ndomains++; - return; + goto cleanup; } if (!(dom = virGetDomain(data->conn, vm->def->name, vm->def->uuid))) { -- 2.47.3