From 4d4f4fd516d032f9873398b9d5b7d89331f95ed8 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 13 Mar 2024 22:44:44 +0100 Subject: [PATCH] virsh: Annotate '--diskspec' _ARGV options as unwanted positional MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Our documentation in most places explicitly mentions --diskspec and it was never meant to be positional, although we can't change the parser any more. Annotate them as 'unwanted_positional'. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- tools/virsh-checkpoint.c | 1 + tools/virsh-snapshot.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/virsh-checkpoint.c b/tools/virsh-checkpoint.c index 869c071700..65061cbf3d 100644 --- a/tools/virsh-checkpoint.c +++ b/tools/virsh-checkpoint.c @@ -206,6 +206,7 @@ static const vshCmdOptDef opts_checkpoint_create_as[] = { }, {.name = "diskspec", .type = VSH_OT_ARGV, + .unwanted_positional = true, .help = N_("disk attributes: disk[,checkpoint=type][,bitmap=name]") }, {.name = NULL} diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 899bae7e9a..638333f4d6 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -361,6 +361,7 @@ static const vshCmdOptDef opts_snapshot_create_as[] = { }, {.name = "diskspec", .type = VSH_OT_ARGV, + .unwanted_positional = true, .help = N_("disk attributes: disk[,snapshot=type][,driver=type][,stype=type][,file=name]") }, {.name = NULL} -- 2.47.3