From 4dbcd896a1dc17a27de9ab9d46602695e59937c9 Mon Sep 17 00:00:00 2001
From: daiwei <daiwei521@126.com>
Date: Thu, 23 Jan 2025 08:36:47 +0800
Subject: [PATCH] wip: warn work with v-for

---
 packages/compiler-core/src/ast.ts              | 2 +-
 packages/compiler-core/src/errors.ts           | 2 ++
 packages/compiler-core/src/transforms/vSkip.ts | 5 +++++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/packages/compiler-core/src/ast.ts b/packages/compiler-core/src/ast.ts
index a3c6bd96c0..2956a4b3dc 100644
--- a/packages/compiler-core/src/ast.ts
+++ b/packages/compiler-core/src/ast.ts
@@ -556,7 +556,7 @@ export interface DynamicSlotFnProperty extends Property {
 export type BlockCodegenNode = VNodeCall | RenderSlotCall
 
 export interface IfConditionalExpression extends ConditionalExpression {
-  consequent: BlockCodegenNode | MemoExpression | ConditionalExpression
+  consequent: BlockCodegenNode | MemoExpression
   alternate: BlockCodegenNode | IfConditionalExpression | MemoExpression
 }
 
diff --git a/packages/compiler-core/src/errors.ts b/packages/compiler-core/src/errors.ts
index b5b5e8cd3e..048902be60 100644
--- a/packages/compiler-core/src/errors.ts
+++ b/packages/compiler-core/src/errors.ts
@@ -93,6 +93,7 @@ export enum ErrorCodes {
   X_V_SKIP_NO_EXPRESSION,
   X_V_SKIP_ON_TEMPLATE,
   X_V_SKIP_UNEXPECTED_SLOT,
+  X_V_SKIP_WITH_V_FOR,
 
   // generic errors
   X_PREFIX_ID_NOT_SUPPORTED,
@@ -185,6 +186,7 @@ export const errorMessages: Record<ErrorCodes, string> = {
   [ErrorCodes.X_V_SKIP_NO_EXPRESSION]: `v-skip is missing expression.`,
   [ErrorCodes.X_V_SKIP_ON_TEMPLATE]: `v-skip cannot be used on <template> or <slot> tags.`,
   [ErrorCodes.X_V_SKIP_UNEXPECTED_SLOT]: `v-skip directive requires the component to have a default slot without slot props`,
+  [ErrorCodes.X_V_SKIP_WITH_V_FOR]: `v-skip with v-for is not supported.`,
 
   // generic errors
   [ErrorCodes.X_PREFIX_ID_NOT_SUPPORTED]: `"prefixIdentifiers" option is not supported in this build of compiler.`,
diff --git a/packages/compiler-core/src/transforms/vSkip.ts b/packages/compiler-core/src/transforms/vSkip.ts
index d1568ef6be..2e5d7a42f0 100644
--- a/packages/compiler-core/src/transforms/vSkip.ts
+++ b/packages/compiler-core/src/transforms/vSkip.ts
@@ -15,6 +15,7 @@ import {
 import {
   ErrorCodes,
   createCompilerError,
+  findDir,
   findProp,
   isSlotOutlet,
   isTemplateNode,
@@ -32,6 +33,10 @@ export const transformSkip: NodeTransform = createStructuralDirectiveTransform(
       return
     }
 
+    if (findDir(node, 'for')) {
+      context.onWarn(createCompilerError(ErrorCodes.X_V_SKIP_WITH_V_FOR, loc))
+    }
+
     if (!dir.exp || !(dir.exp as SimpleExpressionNode).content.trim()) {
       context.onError(
         createCompilerError(ErrorCodes.X_V_SKIP_NO_EXPRESSION, loc),
-- 
2.47.2