From 4f727b919adcc05640d941fdbf623dc2b9fbb464 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 20 Sep 2024 15:46:01 +0200 Subject: [PATCH] lsasrv: Simplify dcesrv_lsa_AddRemoveAccountRights() Use dom_sid_string_buf, no need to talloc. Signed-off-by: Volker Lendecke Reviewed-by: Ralph Boehme --- source4/rpc_server/lsa/dcesrv_lsa.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/source4/rpc_server/lsa/dcesrv_lsa.c b/source4/rpc_server/lsa/dcesrv_lsa.c index 948e296eade..d497117ea77 100644 --- a/source4/rpc_server/lsa/dcesrv_lsa.c +++ b/source4/rpc_server/lsa/dcesrv_lsa.c @@ -3059,7 +3059,8 @@ static NTSTATUS dcesrv_lsa_AddRemoveAccountRights(struct dcesrv_call_state *dce_ { struct auth_session_info *session_info = dcesrv_call_session_info(dce_call); - const char *sidstr, *sidndrstr; + struct dom_sid_buf sidbuf; + const char *sidndrstr = NULL; struct ldb_message *msg; struct ldb_message_element *el; int ret; @@ -3084,13 +3085,7 @@ static NTSTATUS dcesrv_lsa_AddRemoveAccountRights(struct dcesrv_call_state *dce_ return NT_STATUS_NO_MEMORY; } - sidstr = dom_sid_string(msg, sid); - if (sidstr == NULL) { - TALLOC_FREE(msg); - return NT_STATUS_NO_MEMORY; - } - - dnstr = talloc_asprintf(msg, "sid=%s", sidstr); + dnstr = talloc_asprintf(msg, "sid=%s", dom_sid_str_buf(sid, &sidbuf)); if (dnstr == NULL) { TALLOC_FREE(msg); return NT_STATUS_NO_MEMORY; -- 2.47.2