From 4f9feabcd015385f922a3d3f7517e07bb96e5ca7 Mon Sep 17 00:00:00 2001 From: Eric Covener Date: Mon, 1 Mar 2021 20:39:58 +0000 Subject: [PATCH] move to stalled git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1887056 13f79535-47bb-0310-9956-ffa450edef68 --- STATUS | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/STATUS b/STATUS index 1c730fb1e27..e63abc41e42 100644 --- a/STATUS +++ b/STATUS @@ -365,6 +365,25 @@ PATCHES/ISSUES THAT ARE BEING WORKED PATCHES/ISSUES THAT ARE STALLED + *) core: avoid duplicate headers when using ap_send_error_response. + From trunk's testing the code seems running fine without any side + effects, so adding this change in here to have more reviews. + trunk patch: http://svn.apache.org/r1832092 + 2.4.x patch: svn merge -c 1832092 ^/httpd/httpd/trunk . + +1: elukey + +0.5: icing: as I read this, the change preserves the special status of headers in + ->err_headers_out, since swapping the tables makes former error headers normal ones. + But it is hard to see of this was ever intentional or not. Lack of regressions + in testing may meaning someone out there relies on the former, unverified + behaviour. OTOH, it fixes and error you saw and added test for. So, I am cautiously + for the change. + elukey: PR 62025 seems another use case that gets fixed using this patch + (still need to get feedback from the reporter but on my local env it solves the problem). + elukey: If anybody has time to review this change it would be great, to know if it needs to be reverted, + reworked, etc.. I would like to avoid a patch that is clearly wrong for some reviewer sitting here for + months/years without any action item :) + ylavic: will look at it ASAP.. + * core: Add ap_errorlog_provider to make ErrorLog logging modular. This backport keeps syslog logging as part of httpd core and only adds API to allow other modules to be used for error logging. -- 2.47.3