From 51f354a7cffd5034e94b8cd85eb4cf17f00789f8 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Thu, 20 May 2021 10:40:37 +0200 Subject: [PATCH] 4.14-stable patches added patches: ip6_tunnel-sit-proper-dev_-hold-put-in-ndo_init-methods.patch ipv6-remove-extra-dev_hold-for-fallback-tunnels.patch sit-proper-dev_-hold-put-in-ndo_init-methods.patch xhci-do-not-use-gfp_kernel-in-potentially-atomic-context.patch --- ...er-dev_-hold-put-in-ndo_init-methods.patch | 96 +++++++++++++++++++ ...-extra-dev_hold-for-fallback-tunnels.patch | 82 ++++++++++++++++ ...fix-potential-deadlock-in-rs485-mode.patch | 11 +-- queue-4.14/series | 4 + ...er-dev_-hold-put-in-ndo_init-methods.patch | 52 ++++++++++ ...kernel-in-potentially-atomic-context.patch | 60 ++++++++++++ 6 files changed, 297 insertions(+), 8 deletions(-) create mode 100644 queue-4.14/ip6_tunnel-sit-proper-dev_-hold-put-in-ndo_init-methods.patch create mode 100644 queue-4.14/ipv6-remove-extra-dev_hold-for-fallback-tunnels.patch create mode 100644 queue-4.14/sit-proper-dev_-hold-put-in-ndo_init-methods.patch create mode 100644 queue-4.14/xhci-do-not-use-gfp_kernel-in-potentially-atomic-context.patch diff --git a/queue-4.14/ip6_tunnel-sit-proper-dev_-hold-put-in-ndo_init-methods.patch b/queue-4.14/ip6_tunnel-sit-proper-dev_-hold-put-in-ndo_init-methods.patch new file mode 100644 index 00000000000..1d4de6fb64b --- /dev/null +++ b/queue-4.14/ip6_tunnel-sit-proper-dev_-hold-put-in-ndo_init-methods.patch @@ -0,0 +1,96 @@ +From 48bb5697269a7cbe5194dbb044dc38c517e34c58 Mon Sep 17 00:00:00 2001 +From: Eric Dumazet +Date: Mon, 29 Mar 2021 23:45:51 -0700 +Subject: ip6_tunnel: sit: proper dev_{hold|put} in ndo_[un]init methods + +From: Eric Dumazet + +commit 48bb5697269a7cbe5194dbb044dc38c517e34c58 upstream. + +Same reasons than for the previous commits : +6289a98f0817 ("sit: proper dev_{hold|put} in ndo_[un]init methods") +40cb881b5aaa ("ip6_vti: proper dev_{hold|put} in ndo_[un]init methods") +7f700334be9a ("ip6_gre: proper dev_{hold|put} in ndo_[un]init methods") + +After adopting CONFIG_PCPU_DEV_REFCNT=n option, syzbot was able to trigger +a warning [1] + +Issue here is that: + +- all dev_put() should be paired with a corresponding prior dev_hold(). + +- A driver doing a dev_put() in its ndo_uninit() MUST also + do a dev_hold() in its ndo_init(), only when ndo_init() + is returning 0. + +Otherwise, register_netdevice() would call ndo_uninit() +in its error path and release a refcount too soon. + +[1] +WARNING: CPU: 1 PID: 21059 at lib/refcount.c:31 refcount_warn_saturate+0xbf/0x1e0 lib/refcount.c:31 +Modules linked in: +CPU: 1 PID: 21059 Comm: syz-executor.4 Not tainted 5.12.0-rc4-syzkaller #0 +Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 +RIP: 0010:refcount_warn_saturate+0xbf/0x1e0 lib/refcount.c:31 +Code: 1d 6a 5a e8 09 31 ff 89 de e8 8d 1a ab fd 84 db 75 e0 e8 d4 13 ab fd 48 c7 c7 a0 e1 c1 89 c6 05 4a 5a e8 09 01 e8 2e 36 fb 04 <0f> 0b eb c4 e8 b8 13 ab fd 0f b6 1d 39 5a e8 09 31 ff 89 de e8 58 +RSP: 0018:ffffc900025aefe8 EFLAGS: 00010282 +RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 +RDX: 0000000000040000 RSI: ffffffff815c51f5 RDI: fffff520004b5def +RBP: 0000000000000004 R08: 0000000000000000 R09: 0000000000000000 +R10: ffffffff815bdf8e R11: 0000000000000000 R12: ffff888023488568 +R13: ffff8880254e9000 R14: 00000000dfd82cfd R15: ffff88802ee2d7c0 +FS: 00007f13bc590700(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000 +CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 +CR2: 00007f0943e74000 CR3: 0000000025273000 CR4: 00000000001506f0 +DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 +DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 +Call Trace: + __refcount_dec include/linux/refcount.h:344 [inline] + refcount_dec include/linux/refcount.h:359 [inline] + dev_put include/linux/netdevice.h:4135 [inline] + ip6_tnl_dev_uninit+0x370/0x3d0 net/ipv6/ip6_tunnel.c:387 + register_netdevice+0xadf/0x1500 net/core/dev.c:10308 + ip6_tnl_create2+0x1b5/0x400 net/ipv6/ip6_tunnel.c:263 + ip6_tnl_newlink+0x312/0x580 net/ipv6/ip6_tunnel.c:2052 + __rtnl_newlink+0x1062/0x1710 net/core/rtnetlink.c:3443 + rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3491 + rtnetlink_rcv_msg+0x44e/0xad0 net/core/rtnetlink.c:5553 + netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2502 + netlink_unicast_kernel net/netlink/af_netlink.c:1312 [inline] + netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1338 + netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1927 + sock_sendmsg_nosec net/socket.c:654 [inline] + sock_sendmsg+0xcf/0x120 net/socket.c:674 + ____sys_sendmsg+0x6e8/0x810 net/socket.c:2350 + ___sys_sendmsg+0xf3/0x170 net/socket.c:2404 + __sys_sendmsg+0xe5/0x1b0 net/socket.c:2433 + do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 + entry_SYSCALL_64_after_hwframe+0x44/0xae + +Fixes: 919067cc845f ("net: add CONFIG_PCPU_DEV_REFCNT") +Signed-off-by: Eric Dumazet +Reported-by: syzbot +Signed-off-by: David S. Miller +Signed-off-by: Greg Kroah-Hartman +--- + net/ipv6/ip6_tunnel.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/net/ipv6/ip6_tunnel.c ++++ b/net/ipv6/ip6_tunnel.c +@@ -272,7 +272,6 @@ static int ip6_tnl_create2(struct net_de + + strcpy(t->parms.name, dev->name); + +- dev_hold(dev); + ip6_tnl_link(ip6n, t); + return 0; + +@@ -1862,6 +1861,7 @@ ip6_tnl_dev_init_gen(struct net_device * + dev->min_mtu = ETH_MIN_MTU; + dev->max_mtu = IP6_MAX_MTU - dev->hard_header_len; + ++ dev_hold(dev); + return 0; + + destroy_dst: diff --git a/queue-4.14/ipv6-remove-extra-dev_hold-for-fallback-tunnels.patch b/queue-4.14/ipv6-remove-extra-dev_hold-for-fallback-tunnels.patch new file mode 100644 index 00000000000..1d8efe04674 --- /dev/null +++ b/queue-4.14/ipv6-remove-extra-dev_hold-for-fallback-tunnels.patch @@ -0,0 +1,82 @@ +From 0d7a7b2014b1a499a0fe24c9f3063d7856b5aaaf Mon Sep 17 00:00:00 2001 +From: Eric Dumazet +Date: Wed, 31 Mar 2021 14:38:11 -0700 +Subject: ipv6: remove extra dev_hold() for fallback tunnels + +From: Eric Dumazet + +commit 0d7a7b2014b1a499a0fe24c9f3063d7856b5aaaf upstream. + +My previous commits added a dev_hold() in tunnels ndo_init(), +but forgot to remove it from special functions setting up fallback tunnels. + +Fallback tunnels do call their respective ndo_init() + +This leads to various reports like : + +unregister_netdevice: waiting for ip6gre0 to become free. Usage count = 2 + +Fixes: 48bb5697269a ("ip6_tunnel: sit: proper dev_{hold|put} in ndo_[un]init methods") +Fixes: 6289a98f0817 ("sit: proper dev_{hold|put} in ndo_[un]init methods") +Fixes: 40cb881b5aaa ("ip6_vti: proper dev_{hold|put} in ndo_[un]init methods") +Fixes: 7f700334be9a ("ip6_gre: proper dev_{hold|put} in ndo_[un]init methods") +Signed-off-by: Eric Dumazet +Reported-by: syzbot +Signed-off-by: David S. Miller +Signed-off-by: Greg Kroah-Hartman +--- + net/ipv6/ip6_gre.c | 3 --- + net/ipv6/ip6_tunnel.c | 1 - + net/ipv6/ip6_vti.c | 1 - + net/ipv6/sit.c | 1 - + 4 files changed, 6 deletions(-) + +--- a/net/ipv6/ip6_gre.c ++++ b/net/ipv6/ip6_gre.c +@@ -350,7 +350,6 @@ static struct ip6_tnl *ip6gre_tunnel_loc + if (!(nt->parms.o_flags & TUNNEL_SEQ)) + dev->features |= NETIF_F_LLTX; + +- dev_hold(dev); + ip6gre_tunnel_link(ign, nt); + return nt; + +@@ -1124,8 +1123,6 @@ static void ip6gre_fb_tunnel_init(struct + strcpy(tunnel->parms.name, dev->name); + + tunnel->hlen = sizeof(struct ipv6hdr) + 4; +- +- dev_hold(dev); + } + + +--- a/net/ipv6/ip6_tunnel.c ++++ b/net/ipv6/ip6_tunnel.c +@@ -1905,7 +1905,6 @@ static int __net_init ip6_fb_tnl_dev_ini + struct ip6_tnl_net *ip6n = net_generic(net, ip6_tnl_net_id); + + t->parms.proto = IPPROTO_IPV6; +- dev_hold(dev); + + rcu_assign_pointer(ip6n->tnls_wc[0], t); + return 0; +--- a/net/ipv6/ip6_vti.c ++++ b/net/ipv6/ip6_vti.c +@@ -934,7 +934,6 @@ static int __net_init vti6_fb_tnl_dev_in + struct vti6_net *ip6n = net_generic(net, vti6_net_id); + + t->parms.proto = IPPROTO_IPV6; +- dev_hold(dev); + + rcu_assign_pointer(ip6n->tnls_wc[0], t); + return 0; +--- a/net/ipv6/sit.c ++++ b/net/ipv6/sit.c +@@ -1407,7 +1407,6 @@ static void __net_init ipip6_fb_tunnel_i + iph->ihl = 5; + iph->ttl = 64; + +- dev_hold(dev); + rcu_assign_pointer(sitn->tunnels_wc[0], tunnel); + } + diff --git a/queue-4.14/serial-8250-fix-potential-deadlock-in-rs485-mode.patch b/queue-4.14/serial-8250-fix-potential-deadlock-in-rs485-mode.patch index 84cd4c5be97..8aa3de1bdb5 100644 --- a/queue-4.14/serial-8250-fix-potential-deadlock-in-rs485-mode.patch +++ b/queue-4.14/serial-8250-fix-potential-deadlock-in-rs485-mode.patch @@ -33,14 +33,12 @@ Signed-off-by: Tomas Melin Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- - drivers/tty/serial/8250/8250_port.c | 3 --- + drivers/tty/serial/8250/8250_port.c | 3 --- 1 file changed, 3 deletions(-) -diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c -index 9880a50d664f..25e8ccd6865a 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c -@@ -1527,7 +1527,6 @@ static inline void __stop_tx(struct uart_8250_port *p) +@@ -1527,7 +1527,6 @@ static inline void __stop_tx(struct uart return; em485->active_timer = NULL; @@ -48,7 +46,7 @@ index 9880a50d664f..25e8ccd6865a 100644 __stop_tx_rs485(p); } -@@ -1591,8 +1590,6 @@ static inline void start_tx_rs485(struct uart_port *port) +@@ -1591,8 +1590,6 @@ static inline void start_tx_rs485(struct serial8250_stop_rx(&up->port); em485->active_timer = NULL; @@ -57,6 +55,3 @@ index 9880a50d664f..25e8ccd6865a 100644 mcr = serial8250_in_MCR(up); if (!!(up->port.rs485.flags & SER_RS485_RTS_ON_SEND) != --- -2.30.2 - diff --git a/queue-4.14/series b/queue-4.14/series index d65b2b5adad..0503ef69b50 100644 --- a/queue-4.14/series +++ b/queue-4.14/series @@ -317,3 +317,7 @@ alsa-hda-generic-change-the-dac-ctl-name-for-lo-spk-.patch block-reexpand-iov_iter-after-read-write.patch lib-stackdepot-turn-depot_lock-spinlock-to-raw_spinl.patch serial-8250-fix-potential-deadlock-in-rs485-mode.patch +sit-proper-dev_-hold-put-in-ndo_init-methods.patch +ip6_tunnel-sit-proper-dev_-hold-put-in-ndo_init-methods.patch +xhci-do-not-use-gfp_kernel-in-potentially-atomic-context.patch +ipv6-remove-extra-dev_hold-for-fallback-tunnels.patch diff --git a/queue-4.14/sit-proper-dev_-hold-put-in-ndo_init-methods.patch b/queue-4.14/sit-proper-dev_-hold-put-in-ndo_init-methods.patch new file mode 100644 index 00000000000..9d0914a8af1 --- /dev/null +++ b/queue-4.14/sit-proper-dev_-hold-put-in-ndo_init-methods.patch @@ -0,0 +1,52 @@ +From 6289a98f0817a4a457750d6345e754838eae9439 Mon Sep 17 00:00:00 2001 +From: Eric Dumazet +Date: Mon, 29 Mar 2021 12:25:22 -0700 +Subject: sit: proper dev_{hold|put} in ndo_[un]init methods + +From: Eric Dumazet + +commit 6289a98f0817a4a457750d6345e754838eae9439 upstream. + +After adopting CONFIG_PCPU_DEV_REFCNT=n option, syzbot was able to trigger +a warning [1] + +Issue here is that: + +- all dev_put() should be paired with a corresponding prior dev_hold(). + +- A driver doing a dev_put() in its ndo_uninit() MUST also + do a dev_hold() in its ndo_init(), only when ndo_init() + is returning 0. + +Otherwise, register_netdevice() would call ndo_uninit() +in its error path and release a refcount too soon. + +Fixes: 919067cc845f ("net: add CONFIG_PCPU_DEV_REFCNT") +Signed-off-by: Eric Dumazet +Reported-by: syzbot +Signed-off-by: David S. Miller +Signed-off-by: Greg Kroah-Hartman +--- + net/ipv6/sit.c | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +--- a/net/ipv6/sit.c ++++ b/net/ipv6/sit.c +@@ -209,8 +209,6 @@ static int ipip6_tunnel_create(struct ne + + ipip6_tunnel_clone_6rd(dev, sitn); + +- dev_hold(dev); +- + ipip6_tunnel_link(sitn, t); + return 0; + +@@ -1393,7 +1391,7 @@ static int ipip6_tunnel_init(struct net_ + dev->tstats = NULL; + return err; + } +- ++ dev_hold(dev); + return 0; + } + diff --git a/queue-4.14/xhci-do-not-use-gfp_kernel-in-potentially-atomic-context.patch b/queue-4.14/xhci-do-not-use-gfp_kernel-in-potentially-atomic-context.patch new file mode 100644 index 00000000000..47ea52a15a9 --- /dev/null +++ b/queue-4.14/xhci-do-not-use-gfp_kernel-in-potentially-atomic-context.patch @@ -0,0 +1,60 @@ +From dda32c00c9a0fa103b5d54ef72c477b7aa993679 Mon Sep 17 00:00:00 2001 +From: Christophe JAILLET +Date: Wed, 12 May 2021 11:08:14 +0300 +Subject: xhci: Do not use GFP_KERNEL in (potentially) atomic context + +From: Christophe JAILLET + +commit dda32c00c9a0fa103b5d54ef72c477b7aa993679 upstream. + +'xhci_urb_enqueue()' is passed a 'mem_flags' argument, because "URBs may be +submitted in interrupt context" (see comment related to 'usb_submit_urb()' +in 'drivers/usb/core/urb.c') + +So this flag should be used in all the calling chain. +Up to now, 'xhci_check_maxpacket()' which is only called from +'xhci_urb_enqueue()', uses GFP_KERNEL. + +Be safe and pass the mem_flags to this function as well. + +Fixes: ddba5cd0aeff ("xhci: Use command structures when queuing commands on the command ring") +Cc: +Signed-off-by: Christophe JAILLET +Signed-off-by: Mathias Nyman +Link: https://lore.kernel.org/r/20210512080816.866037-4-mathias.nyman@linux.intel.com +[iwamatsu: Adjust context] +Signed-off-by: Nobuhiro Iwamatsu +Signed-off-by: Greg Kroah-Hartman +--- + drivers/usb/host/xhci.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +--- a/drivers/usb/host/xhci.c ++++ b/drivers/usb/host/xhci.c +@@ -1308,7 +1308,7 @@ static int xhci_configure_endpoint(struc + * we need to issue an evaluate context command and wait on it. + */ + static int xhci_check_maxpacket(struct xhci_hcd *xhci, unsigned int slot_id, +- unsigned int ep_index, struct urb *urb) ++ unsigned int ep_index, struct urb *urb, gfp_t mem_flags) + { + struct xhci_container_ctx *out_ctx; + struct xhci_input_control_ctx *ctrl_ctx; +@@ -1339,7 +1339,7 @@ static int xhci_check_maxpacket(struct x + * changes max packet sizes. + */ + +- command = xhci_alloc_command(xhci, false, true, GFP_KERNEL); ++ command = xhci_alloc_command(xhci, false, true, mem_flags); + if (!command) + return -ENOMEM; + +@@ -1430,7 +1430,7 @@ static int xhci_urb_enqueue(struct usb_h + */ + if (urb->dev->speed == USB_SPEED_FULL) { + ret = xhci_check_maxpacket(xhci, slot_id, +- ep_index, urb); ++ ep_index, urb, mem_flags); + if (ret < 0) { + xhci_urb_free_priv(urb_priv); + urb->hcpriv = NULL; -- 2.47.3