From 522e0374578f1877f82a8a2ce1bdd5c004af20bb Mon Sep 17 00:00:00 2001 From: Sasha Levin Date: Wed, 15 Mar 2023 13:57:56 -0400 Subject: [PATCH] Drop powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch Signed-off-by: Sasha Levin --- ...q-instead-of-irq-no_irq-and-remove-n.patch | 72 ------------------- queue-5.10/series | 1 - ...q-instead-of-irq-no_irq-and-remove-n.patch | 72 ------------------- queue-5.15/series | 1 - ...q-instead-of-irq-no_irq-and-remove-n.patch | 72 ------------------- queue-5.4/series | 1 - ...q-instead-of-irq-no_irq-and-remove-n.patch | 72 ------------------- queue-6.1/series | 1 - ...q-instead-of-irq-no_irq-and-remove-n.patch | 72 ------------------- queue-6.2/series | 1 - 10 files changed, 365 deletions(-) delete mode 100644 queue-5.10/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch delete mode 100644 queue-5.15/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch delete mode 100644 queue-5.4/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch delete mode 100644 queue-6.1/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch delete mode 100644 queue-6.2/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch diff --git a/queue-5.10/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch b/queue-5.10/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch deleted file mode 100644 index f298c8d5037..00000000000 --- a/queue-5.10/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch +++ /dev/null @@ -1,72 +0,0 @@ -From f0ccf25438430cadcd51d6d50e297ed09bf216eb Mon Sep 17 00:00:00 2001 -From: Sasha Levin -Date: Mon, 23 Jan 2023 13:26:46 +0100 -Subject: powerpc: Check !irq instead of irq == NO_IRQ and remove NO_IRQ - -From: Christophe Leroy - -[ Upstream commit bab537805a10bdbf55b31324ba4a9599e0651e5e ] - -NO_IRQ is a relic from the old days. It is not used anymore in core -functions. By the way, function irq_of_parse_and_map() returns value 0 -on error. - -In some drivers, NO_IRQ is erroneously used to check the return of -irq_of_parse_and_map(). - -It is not a real bug today because the only architectures using the -drivers being fixed by this patch define NO_IRQ as 0, but there are -architectures which define NO_IRQ as -1. If one day those -architectures start using the non fixed drivers, there will be a -problem. - -Long time ago Linus advocated for not using NO_IRQ, see -https://lore.kernel.org/all/Pine.LNX.4.64.0511211150040.13959@g5.osdl.org - -He re-iterated the same view recently in -https://lore.kernel.org/all/CAHk-=wg2Pkb9kbfbstbB91AJA2SF6cySbsgHG-iQMq56j3VTcA@mail.gmail.com - -So test !irq instead of tesing irq == NO_IRQ. - -All other usage of NO_IRQ for powerpc were removed in previous cycles so -the time has come to remove NO_IRQ completely for powerpc. - -Signed-off-by: Christophe Leroy -Signed-off-by: Michael Ellerman -Link: https://lore.kernel.org/r/4b8d4f96140af01dec3a3330924dda8b2451c316.1674476798.git.christophe.leroy@csgroup.eu -Signed-off-by: Sasha Levin ---- - arch/powerpc/include/asm/irq.h | 3 --- - arch/powerpc/platforms/44x/fsp2.c | 2 +- - 2 files changed, 1 insertion(+), 4 deletions(-) - -diff --git a/arch/powerpc/include/asm/irq.h b/arch/powerpc/include/asm/irq.h -index 4f983ca4030a4..4d5e68e6d3b6d 100644 ---- a/arch/powerpc/include/asm/irq.h -+++ b/arch/powerpc/include/asm/irq.h -@@ -17,9 +17,6 @@ - - extern atomic_t ppc_n_lost_interrupts; - --/* This number is used when no interrupt has been assigned */ --#define NO_IRQ (0) -- - /* Total number of virq in the platform */ - #define NR_IRQS CONFIG_NR_IRQS - -diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c -index 823397c802def..f8bbe05d9ef29 100644 ---- a/arch/powerpc/platforms/44x/fsp2.c -+++ b/arch/powerpc/platforms/44x/fsp2.c -@@ -205,7 +205,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler) - - for_each_compatible_node(np, NULL, compat) { - irq = irq_of_parse_and_map(np, 0); -- if (irq == NO_IRQ) { -+ if (!irq) { - pr_err("device tree node %pOFn is missing a interrupt", - np); - of_node_put(np); --- -2.39.2 - diff --git a/queue-5.10/series b/queue-5.10/series index 08ab977f0fa..b2253ba3540 100644 --- a/queue-5.10/series +++ b/queue-5.10/series @@ -65,7 +65,6 @@ block-bfq-replace-0-1-with-false-true-in-bic-apis.patch block-bfq-fix-uaf-for-bfqq-in-bic_set_bfqq.patch clk-qcom-mmcc-apq8084-remove-spdm-clocks.patch mips-fix-a-compilation-issue.patch -powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch powerpc-kcsan-exclude-udelay-to-prevent-recursive-in.patch alpha-fix-r_alpha_literal-reloc-for-large-modules.patch macintosh-windfarm-use-unsigned-type-for-1-bit-bitfi.patch diff --git a/queue-5.15/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch b/queue-5.15/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch deleted file mode 100644 index 66d8263d793..00000000000 --- a/queue-5.15/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch +++ /dev/null @@ -1,72 +0,0 @@ -From b653f9325500ff5e88cf988bcd11dbc766a1ebfb Mon Sep 17 00:00:00 2001 -From: Sasha Levin -Date: Mon, 23 Jan 2023 13:26:46 +0100 -Subject: powerpc: Check !irq instead of irq == NO_IRQ and remove NO_IRQ - -From: Christophe Leroy - -[ Upstream commit bab537805a10bdbf55b31324ba4a9599e0651e5e ] - -NO_IRQ is a relic from the old days. It is not used anymore in core -functions. By the way, function irq_of_parse_and_map() returns value 0 -on error. - -In some drivers, NO_IRQ is erroneously used to check the return of -irq_of_parse_and_map(). - -It is not a real bug today because the only architectures using the -drivers being fixed by this patch define NO_IRQ as 0, but there are -architectures which define NO_IRQ as -1. If one day those -architectures start using the non fixed drivers, there will be a -problem. - -Long time ago Linus advocated for not using NO_IRQ, see -https://lore.kernel.org/all/Pine.LNX.4.64.0511211150040.13959@g5.osdl.org - -He re-iterated the same view recently in -https://lore.kernel.org/all/CAHk-=wg2Pkb9kbfbstbB91AJA2SF6cySbsgHG-iQMq56j3VTcA@mail.gmail.com - -So test !irq instead of tesing irq == NO_IRQ. - -All other usage of NO_IRQ for powerpc were removed in previous cycles so -the time has come to remove NO_IRQ completely for powerpc. - -Signed-off-by: Christophe Leroy -Signed-off-by: Michael Ellerman -Link: https://lore.kernel.org/r/4b8d4f96140af01dec3a3330924dda8b2451c316.1674476798.git.christophe.leroy@csgroup.eu -Signed-off-by: Sasha Levin ---- - arch/powerpc/include/asm/irq.h | 3 --- - arch/powerpc/platforms/44x/fsp2.c | 2 +- - 2 files changed, 1 insertion(+), 4 deletions(-) - -diff --git a/arch/powerpc/include/asm/irq.h b/arch/powerpc/include/asm/irq.h -index 2b3278534bc14..858393f7fd7d7 100644 ---- a/arch/powerpc/include/asm/irq.h -+++ b/arch/powerpc/include/asm/irq.h -@@ -16,9 +16,6 @@ - - extern atomic_t ppc_n_lost_interrupts; - --/* This number is used when no interrupt has been assigned */ --#define NO_IRQ (0) -- - /* Total number of virq in the platform */ - #define NR_IRQS CONFIG_NR_IRQS - -diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c -index 823397c802def..f8bbe05d9ef29 100644 ---- a/arch/powerpc/platforms/44x/fsp2.c -+++ b/arch/powerpc/platforms/44x/fsp2.c -@@ -205,7 +205,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler) - - for_each_compatible_node(np, NULL, compat) { - irq = irq_of_parse_and_map(np, 0); -- if (irq == NO_IRQ) { -+ if (!irq) { - pr_err("device tree node %pOFn is missing a interrupt", - np); - of_node_put(np); --- -2.39.2 - diff --git a/queue-5.15/series b/queue-5.15/series index 2241c2243ba..0a03fccf935 100644 --- a/queue-5.15/series +++ b/queue-5.15/series @@ -104,7 +104,6 @@ attr-use-consistent-sgid-stripping-checks.patch fs-use-consistent-setgid-checks-in-is_sxid.patch clk-qcom-mmcc-apq8084-remove-spdm-clocks.patch mips-fix-a-compilation-issue.patch -powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch powerpc-iommu-fix-memory-leak-with-using-debugfs_loo.patch powerpc-kcsan-exclude-udelay-to-prevent-recursive-in.patch alpha-fix-r_alpha_literal-reloc-for-large-modules.patch diff --git a/queue-5.4/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch b/queue-5.4/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch deleted file mode 100644 index 14d73486eaf..00000000000 --- a/queue-5.4/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch +++ /dev/null @@ -1,72 +0,0 @@ -From e57fb39ccf340b9d71771eff7f25a99a4d6c4e3b Mon Sep 17 00:00:00 2001 -From: Sasha Levin -Date: Mon, 23 Jan 2023 13:26:46 +0100 -Subject: powerpc: Check !irq instead of irq == NO_IRQ and remove NO_IRQ - -From: Christophe Leroy - -[ Upstream commit bab537805a10bdbf55b31324ba4a9599e0651e5e ] - -NO_IRQ is a relic from the old days. It is not used anymore in core -functions. By the way, function irq_of_parse_and_map() returns value 0 -on error. - -In some drivers, NO_IRQ is erroneously used to check the return of -irq_of_parse_and_map(). - -It is not a real bug today because the only architectures using the -drivers being fixed by this patch define NO_IRQ as 0, but there are -architectures which define NO_IRQ as -1. If one day those -architectures start using the non fixed drivers, there will be a -problem. - -Long time ago Linus advocated for not using NO_IRQ, see -https://lore.kernel.org/all/Pine.LNX.4.64.0511211150040.13959@g5.osdl.org - -He re-iterated the same view recently in -https://lore.kernel.org/all/CAHk-=wg2Pkb9kbfbstbB91AJA2SF6cySbsgHG-iQMq56j3VTcA@mail.gmail.com - -So test !irq instead of tesing irq == NO_IRQ. - -All other usage of NO_IRQ for powerpc were removed in previous cycles so -the time has come to remove NO_IRQ completely for powerpc. - -Signed-off-by: Christophe Leroy -Signed-off-by: Michael Ellerman -Link: https://lore.kernel.org/r/4b8d4f96140af01dec3a3330924dda8b2451c316.1674476798.git.christophe.leroy@csgroup.eu -Signed-off-by: Sasha Levin ---- - arch/powerpc/include/asm/irq.h | 3 --- - arch/powerpc/platforms/44x/fsp2.c | 2 +- - 2 files changed, 1 insertion(+), 4 deletions(-) - -diff --git a/arch/powerpc/include/asm/irq.h b/arch/powerpc/include/asm/irq.h -index 814dfab7e392e..f2f952ca87c37 100644 ---- a/arch/powerpc/include/asm/irq.h -+++ b/arch/powerpc/include/asm/irq.h -@@ -17,9 +17,6 @@ - - extern atomic_t ppc_n_lost_interrupts; - --/* This number is used when no interrupt has been assigned */ --#define NO_IRQ (0) -- - /* Total number of virq in the platform */ - #define NR_IRQS CONFIG_NR_IRQS - -diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c -index 823397c802def..f8bbe05d9ef29 100644 ---- a/arch/powerpc/platforms/44x/fsp2.c -+++ b/arch/powerpc/platforms/44x/fsp2.c -@@ -205,7 +205,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler) - - for_each_compatible_node(np, NULL, compat) { - irq = irq_of_parse_and_map(np, 0); -- if (irq == NO_IRQ) { -+ if (!irq) { - pr_err("device tree node %pOFn is missing a interrupt", - np); - of_node_put(np); --- -2.39.2 - diff --git a/queue-5.4/series b/queue-5.4/series index 05a9cf072d1..3f9f7b3c55d 100644 --- a/queue-5.4/series +++ b/queue-5.4/series @@ -49,7 +49,6 @@ riscv-use-read_once_nocheck-in-imprecise-unwinding-s.patch ext4-fix-deadlock-during-directory-rename.patch clk-qcom-mmcc-apq8084-remove-spdm-clocks.patch mips-fix-a-compilation-issue.patch -powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch alpha-fix-r_alpha_literal-reloc-for-large-modules.patch macintosh-windfarm-use-unsigned-type-for-1-bit-bitfi.patch pci-add-solidrun-vendor-id.patch diff --git a/queue-6.1/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch b/queue-6.1/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch deleted file mode 100644 index 518b54bcd5f..00000000000 --- a/queue-6.1/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch +++ /dev/null @@ -1,72 +0,0 @@ -From fd83218773c97b3d8a4b8b978fb9e9fe790a13d0 Mon Sep 17 00:00:00 2001 -From: Sasha Levin -Date: Mon, 23 Jan 2023 13:26:46 +0100 -Subject: powerpc: Check !irq instead of irq == NO_IRQ and remove NO_IRQ - -From: Christophe Leroy - -[ Upstream commit bab537805a10bdbf55b31324ba4a9599e0651e5e ] - -NO_IRQ is a relic from the old days. It is not used anymore in core -functions. By the way, function irq_of_parse_and_map() returns value 0 -on error. - -In some drivers, NO_IRQ is erroneously used to check the return of -irq_of_parse_and_map(). - -It is not a real bug today because the only architectures using the -drivers being fixed by this patch define NO_IRQ as 0, but there are -architectures which define NO_IRQ as -1. If one day those -architectures start using the non fixed drivers, there will be a -problem. - -Long time ago Linus advocated for not using NO_IRQ, see -https://lore.kernel.org/all/Pine.LNX.4.64.0511211150040.13959@g5.osdl.org - -He re-iterated the same view recently in -https://lore.kernel.org/all/CAHk-=wg2Pkb9kbfbstbB91AJA2SF6cySbsgHG-iQMq56j3VTcA@mail.gmail.com - -So test !irq instead of tesing irq == NO_IRQ. - -All other usage of NO_IRQ for powerpc were removed in previous cycles so -the time has come to remove NO_IRQ completely for powerpc. - -Signed-off-by: Christophe Leroy -Signed-off-by: Michael Ellerman -Link: https://lore.kernel.org/r/4b8d4f96140af01dec3a3330924dda8b2451c316.1674476798.git.christophe.leroy@csgroup.eu -Signed-off-by: Sasha Levin ---- - arch/powerpc/include/asm/irq.h | 3 --- - arch/powerpc/platforms/44x/fsp2.c | 2 +- - 2 files changed, 1 insertion(+), 4 deletions(-) - -diff --git a/arch/powerpc/include/asm/irq.h b/arch/powerpc/include/asm/irq.h -index 5c1516a5ba8f6..deadd2149426a 100644 ---- a/arch/powerpc/include/asm/irq.h -+++ b/arch/powerpc/include/asm/irq.h -@@ -16,9 +16,6 @@ - - extern atomic_t ppc_n_lost_interrupts; - --/* This number is used when no interrupt has been assigned */ --#define NO_IRQ (0) -- - /* Total number of virq in the platform */ - #define NR_IRQS CONFIG_NR_IRQS - -diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c -index e2e4f6d8150d6..56d91dbef5770 100644 ---- a/arch/powerpc/platforms/44x/fsp2.c -+++ b/arch/powerpc/platforms/44x/fsp2.c -@@ -205,7 +205,7 @@ static void __init node_irq_request(const char *compat, irq_handler_t errirq_han - - for_each_compatible_node(np, NULL, compat) { - irq = irq_of_parse_and_map(np, 0); -- if (irq == NO_IRQ) { -+ if (!irq) { - pr_err("device tree node %pOFn is missing a interrupt", - np); - of_node_put(np); --- -2.39.2 - diff --git a/queue-6.1/series b/queue-6.1/series index 83cdaf96694..6916b23c93b 100644 --- a/queue-6.1/series +++ b/queue-6.1/series @@ -121,7 +121,6 @@ watch_queue-fix-ioc_watch_queue_set_size-alloc-error.patch tpm-eventlog-don-t-abort-tpm_read_log-on-faulty-acpi.patch clk-qcom-mmcc-apq8084-remove-spdm-clocks.patch mips-fix-a-compilation-issue.patch -powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch powerpc-64-don-t-recurse-irq-replay.patch powerpc-iommu-fix-memory-leak-with-using-debugfs_loo.patch clk-renesas-rcar-gen3-disable-r-car-h3-es1.patch diff --git a/queue-6.2/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch b/queue-6.2/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch deleted file mode 100644 index 1d751bd7ccf..00000000000 --- a/queue-6.2/powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch +++ /dev/null @@ -1,72 +0,0 @@ -From c42512f8594ca67910baaee8d4389d9877d2a260 Mon Sep 17 00:00:00 2001 -From: Sasha Levin -Date: Mon, 23 Jan 2023 13:26:46 +0100 -Subject: powerpc: Check !irq instead of irq == NO_IRQ and remove NO_IRQ - -From: Christophe Leroy - -[ Upstream commit bab537805a10bdbf55b31324ba4a9599e0651e5e ] - -NO_IRQ is a relic from the old days. It is not used anymore in core -functions. By the way, function irq_of_parse_and_map() returns value 0 -on error. - -In some drivers, NO_IRQ is erroneously used to check the return of -irq_of_parse_and_map(). - -It is not a real bug today because the only architectures using the -drivers being fixed by this patch define NO_IRQ as 0, but there are -architectures which define NO_IRQ as -1. If one day those -architectures start using the non fixed drivers, there will be a -problem. - -Long time ago Linus advocated for not using NO_IRQ, see -https://lore.kernel.org/all/Pine.LNX.4.64.0511211150040.13959@g5.osdl.org - -He re-iterated the same view recently in -https://lore.kernel.org/all/CAHk-=wg2Pkb9kbfbstbB91AJA2SF6cySbsgHG-iQMq56j3VTcA@mail.gmail.com - -So test !irq instead of tesing irq == NO_IRQ. - -All other usage of NO_IRQ for powerpc were removed in previous cycles so -the time has come to remove NO_IRQ completely for powerpc. - -Signed-off-by: Christophe Leroy -Signed-off-by: Michael Ellerman -Link: https://lore.kernel.org/r/4b8d4f96140af01dec3a3330924dda8b2451c316.1674476798.git.christophe.leroy@csgroup.eu -Signed-off-by: Sasha Levin ---- - arch/powerpc/include/asm/irq.h | 3 --- - arch/powerpc/platforms/44x/fsp2.c | 2 +- - 2 files changed, 1 insertion(+), 4 deletions(-) - -diff --git a/arch/powerpc/include/asm/irq.h b/arch/powerpc/include/asm/irq.h -index 5c1516a5ba8f6..deadd2149426a 100644 ---- a/arch/powerpc/include/asm/irq.h -+++ b/arch/powerpc/include/asm/irq.h -@@ -16,9 +16,6 @@ - - extern atomic_t ppc_n_lost_interrupts; - --/* This number is used when no interrupt has been assigned */ --#define NO_IRQ (0) -- - /* Total number of virq in the platform */ - #define NR_IRQS CONFIG_NR_IRQS - -diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c -index e2e4f6d8150d6..56d91dbef5770 100644 ---- a/arch/powerpc/platforms/44x/fsp2.c -+++ b/arch/powerpc/platforms/44x/fsp2.c -@@ -205,7 +205,7 @@ static void __init node_irq_request(const char *compat, irq_handler_t errirq_han - - for_each_compatible_node(np, NULL, compat) { - irq = irq_of_parse_and_map(np, 0); -- if (irq == NO_IRQ) { -+ if (!irq) { - pr_err("device tree node %pOFn is missing a interrupt", - np); - of_node_put(np); --- -2.39.2 - diff --git a/queue-6.2/series b/queue-6.2/series index 3f501c5937d..454ae68fe72 100644 --- a/queue-6.2/series +++ b/queue-6.2/series @@ -117,7 +117,6 @@ watch_queue-fix-ioc_watch_queue_set_size-alloc-error.patch tpm-eventlog-don-t-abort-tpm_read_log-on-faulty-acpi.patch clk-qcom-mmcc-apq8084-remove-spdm-clocks.patch mips-fix-a-compilation-issue.patch -powerpc-check-irq-instead-of-irq-no_irq-and-remove-n.patch powerpc-64-don-t-recurse-irq-replay.patch powerpc-iommu-fix-memory-leak-with-using-debugfs_loo.patch clk-renesas-rcar-gen3-disable-r-car-h3-es1.patch -- 2.47.3