From 53ca38298d69529e59e33a21e63040aef509bbf8 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Wed, 25 Jun 2025 23:25:10 +0900 Subject: [PATCH] contrib: warn for invalid netrc file ports in git-credential-netrc Invalid ports were previously silently dropped; now a warning message is produced. Signed-off-by: Maxim Cournoyer Signed-off-by: Junio C Hamano --- contrib/credential/netrc/git-credential-netrc.perl | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/contrib/credential/netrc/git-credential-netrc.perl b/contrib/credential/netrc/git-credential-netrc.perl index 514f68d00b..09d77b4f69 100755 --- a/contrib/credential/netrc/git-credential-netrc.perl +++ b/contrib/credential/netrc/git-credential-netrc.perl @@ -267,9 +267,14 @@ sub load_netrc { if (!defined $nentry->{machine}) { next; } - if (defined $nentry->{port} && $nentry->{port} =~ m/^\d+$/) { - $num_port = $nentry->{port}; - delete $nentry->{port}; + if (defined $nentry->{port}) { + if ($nentry->{port} =~ m/^\d+$/) { + $num_port = $nentry->{port}; + delete $nentry->{port}; + } else { + printf(STDERR "ignoring invalid port `%s' " . + "from netrc file\n", $nentry->{port}); + } } # create the new entry for the credential helper protocol -- 2.47.3