From 54b47afedb82822b33a72bb804157a425d2201ff Mon Sep 17 00:00:00 2001 From: Pauli Date: Thu, 23 Apr 2020 20:31:12 +1000 Subject: [PATCH] keymgmt: convert to use the params modification detection. Reviewed-by: Richard Levitte Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/11601) --- crypto/evp/keymgmt_lib.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/crypto/evp/keymgmt_lib.c b/crypto/evp/keymgmt_lib.c index 9ed176410a..3493ceb3cb 100644 --- a/crypto/evp/keymgmt_lib.c +++ b/crypto/evp/keymgmt_lib.c @@ -432,25 +432,23 @@ int evp_keymgmt_util_get_deflt_digest_name(EVP_KEYMGMT *keymgmt, params[0] = OSSL_PARAM_construct_utf8_string(OSSL_PKEY_PARAM_DEFAULT_DIGEST, mddefault, sizeof(mddefault)); - params[0].return_size = sizeof(mddefault) + 1; params[1] = OSSL_PARAM_construct_utf8_string(OSSL_PKEY_PARAM_MANDATORY_DIGEST, mdmandatory, sizeof(mdmandatory)); - params[1].return_size = sizeof(mdmandatory) + 1; params[2] = OSSL_PARAM_construct_end(); if (!evp_keymgmt_get_params(keymgmt, keydata, params)) return 0; - if (params[1].return_size != sizeof(mdmandatory) + 1) { - if (params[1].return_size == 1) /* Only a NUL byte */ + if (OSSL_PARAM_modified(params + 1)) { + if (params[1].return_size <= 1) /* Only a NUL byte */ result = SN_undef; else result = mdmandatory; rv = 2; - } else if (params[0].return_size != sizeof(mddefault) + 1) { - if (params[0].return_size == 1) /* Only a NUL byte */ + } else if (OSSL_PARAM_modified(params)) { + if (params[0].return_size <= 1) /* Only a NUL byte */ result = SN_undef; else result = mddefault; -- 2.39.5