From 5693342ec25646e53fadccc29ee7605374a1376e Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Fri, 28 Feb 2025 23:56:01 +0100 Subject: [PATCH] winbuild: reduce command-line length by dropping whitespace Keep the `@for %%i in [...]` lines within limits by stripping whitespace from the input `.c` source lists read from `Makefile.inc`. To avoid this error after adding a new `.c` source: ``` configuration name: libcurl-vc14-x64-release-dll-ssl-dll-ipv6-sspi NMAKE : fatal error U1095: expanded command line 'for %i in (altsvc.obj amigaos.obj asyn-ares.obj asyn-thread.obj base64.obj bufq.obj bufref.obj cf-h1-proxy.obj cf-h2-proxy.obj cf-haproxy.obj [...] vssh/wolfssh.obj) do @echo ..\builds\libcurl-vc14-x64-release-dll-ssl-dll-ipv6-sspi-obj-lib/%i \ ' too long Stop. Command exited with code 2 ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/51605338/job/dqg6qtebtscb279g#L44 Reported-by: Stefan Eissing Bug: https://github.com/curl/curl/pull/16508#issuecomment-2690443409 Fixes #16521 Closes #16528 --- winbuild/Makefile.vc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/winbuild/Makefile.vc b/winbuild/Makefile.vc index d404279dd3..1f1e6d550c 100644 --- a/winbuild/Makefile.vc +++ b/winbuild/Makefile.vc @@ -58,9 +58,11 @@ CFGSET=true !ENDIF !INCLUDE "../lib/Makefile.inc" +CSOURCES=$(CSOURCES: = ) LIBCURL_OBJS=$(CSOURCES:.c=.obj) !INCLUDE "../src/Makefile.inc" +CURL_CFILES=$(CURL_CFILES: = ) CURL_OBJS=$(CURL_CFILES:.c=.obj) -- 2.47.2