From 5ac73acf123d75dc8091301d113a33964cae5931 Mon Sep 17 00:00:00 2001 From: Jouni Malinen Date: Sat, 13 Dec 2014 19:15:38 +0200 Subject: [PATCH] Simplify eapol_sm_get_mib() result handling This function cannot return negative value, so no need to check for that. If there is not enough room in the buffer or if something unexpected happens, 0 is returned. Signed-off-by: Jouni Malinen --- wpa_supplicant/ctrl_iface.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/wpa_supplicant/ctrl_iface.c b/wpa_supplicant/ctrl_iface.c index 74fab9fdc..c663512fe 100644 --- a/wpa_supplicant/ctrl_iface.c +++ b/wpa_supplicant/ctrl_iface.c @@ -7021,13 +7021,9 @@ char * wpa_supplicant_ctrl_iface_process(struct wpa_supplicant *wpa_s, } else if (os_strcmp(buf, "MIB") == 0) { reply_len = wpa_sm_get_mib(wpa_s->wpa, reply, reply_size); if (reply_len >= 0) { - int res; - res = eapol_sm_get_mib(wpa_s->eapol, reply + reply_len, - reply_size - reply_len); - if (res < 0) - reply_len = -1; - else - reply_len += res; + reply_len += eapol_sm_get_mib(wpa_s->eapol, + reply + reply_len, + reply_size - reply_len); } } else if (os_strncmp(buf, "STATUS", 6) == 0) { reply_len = wpa_supplicant_ctrl_iface_status( -- 2.39.5