From 5ae1605fc22acf672f46ba08f6b2ef4f675e92b8 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 23 May 2024 16:12:53 +0200 Subject: [PATCH] lib: Fix an error path memleak Signed-off-by: Volker Lendecke Reviewed-by: Andrew Bartlett --- lib/util/asn1.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/util/asn1.c b/lib/util/asn1.c index 52b91b51d00..4ce85e9b0d9 100644 --- a/lib/util/asn1.c +++ b/lib/util/asn1.c @@ -308,8 +308,11 @@ bool ber_write_OID_String(TALLOC_CTX *mem_ctx, DATA_BLOB *blob, const char *OID) v = smb_strtoul(p, &newp, 10, &error, SMB_STR_STANDARD); if (newp[0] == '.' || error != 0) { p = newp + 1; - /* check for empty last component */ - if (!*p) return false; + if (!*p) { + /* empty last component */ + data_blob_free(blob); + return false; + } } else if (newp[0] == '\0') { p = newp; } else { -- 2.47.3