From 5b904b58121032c65b8c5bd2d14fece880036e6b Mon Sep 17 00:00:00 2001 From: David Lawrence Date: Mon, 25 Jul 2011 01:29:43 -0400 Subject: [PATCH] Bug 652663 - When using bug_format_comment hook some replacements can happen more than once causing broken links r/a=LpSolit --- Bugzilla/Template.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm index f58128eec0..4320121bfb 100644 --- a/Bugzilla/Template.pm +++ b/Bugzilla/Template.pm @@ -257,8 +257,10 @@ sub quoteUrls { ~get_bug_link($1, $1) ~egmx; - # Now remove the encoding hacks - $text =~ s/\0\0(\d+)\0\0/$things[$1]/eg; + # Now remove the encoding hacks in reverse order + for (my $i = $#things; $i >= 0; $i--) { + $text =~ s/\0\0($i)\0\0/$things[$i]/eg; + } $text =~ s/$chr1\0/\0/g; return $text; -- 2.47.3