From 5fb53d39cd0af1b3c5b4ff8a79c7a3c2a215ff48 Mon Sep 17 00:00:00 2001 From: Aki Tuomi Date: Thu, 16 Jan 2025 15:39:34 +0200 Subject: [PATCH] auth: userdb sql - Fail if iterate_query is not set Otherwise we end up with panic. --- src/auth/userdb-sql.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/auth/userdb-sql.c b/src/auth/userdb-sql.c index 576076044d..c508193392 100644 --- a/src/auth/userdb-sql.c +++ b/src/auth/userdb-sql.c @@ -187,8 +187,14 @@ userdb_sql_iterate_init(struct auth_request *auth_request, return &ctx->ctx; } - sql_query(module->db, set->iterate_query, sql_iter_query_callback, ctx); - e_debug(authdb_event(auth_request), "%s", set->iterate_query); + if (*set->iterate_query == '\0') { + e_error(authdb_event(auth_request), "User iteration failed: " + "userdb_sql_iterate_query is empty"); + ctx->ctx.failed = TRUE; + } else { + sql_query(module->db, set->iterate_query, sql_iter_query_callback, ctx); + e_debug(authdb_event(auth_request), "%s", set->iterate_query); + } settings_free(set); return &ctx->ctx; } -- 2.47.3