From 616d64ac06c1bc8ad4954827b0655c59169e8585 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Mon, 18 Dec 2017 19:12:19 +0000 Subject: [PATCH] ui: avoid pointless VNC updates if framebuffer isn't dirty MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The vnc_update_client() method checks the 'has_dirty' flag to see if there are dirty regions that are pending to send to the client. Regardless of this flag, if a forced update is requested, updates must be sent. For unknown reasons though, the code also tries to sent updates if audio capture is enabled. This makes no sense as audio capture state does not impact framebuffer contents, so this check is removed. Signed-off-by: Daniel P. Berrange Reviewed-by: Darren Kenny Reviewed-by: Marc-André Lureau Message-id: 20171218191228.31018-5-berrange@redhat.com Signed-off-by: Gerd Hoffmann (cherry picked from commit 3541b08475d51bddf8aded36576a0ff5a547a978) Signed-off-by: Michael Roth --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index a61fcbd20c0..f53eddb8e5b 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -984,7 +984,7 @@ static int vnc_update_client(VncState *vs, int has_dirty) return 0; } - if (!vs->has_dirty && !vs->audio_cap && !vs->force_update) { + if (!vs->has_dirty && !vs->force_update) { return 0; } -- 2.39.5