From 61a7c9df71ee4e6f94b56c20f0d37c6e17d5f284 Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Mon, 2 Dec 2019 14:53:16 +0100 Subject: [PATCH] elf/tst-dlopenfail: Disable --no-as-needed for tst-dlopenfailmod1.so Otherwise, the shared object dependency which triggers the load failure is dropped, invalidating the test. --- elf/Makefile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/elf/Makefile b/elf/Makefile index 305bed2d38e..f7adebec880 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -1602,8 +1602,11 @@ LDFLAGS-tst-finilazyfailmod.so = \ $(objpfx)tst-dlopenfail: $(libdl) $(objpfx)tst-dlopenfail.out: \ $(objpfx)tst-dlopenfailmod1.so $(objpfx)tst-dlopenfailmod2.so -# Order matters here. tst-dlopenfaillinkmod.so's soname ensures -# a run-time loader failure. +# Order matters here. tst-dlopenfaillinkmod.so's soname ensures a +# run-time loader failure. --as-needed breaks this test because +# nothing actually references tst-dlopenfailmod2.so (with its soname +# tst-dlopenfail-missingmod.so). +LDFLAGS-tst-dlopenfailmod1.so = -Wl,--no-as-needed $(objpfx)tst-dlopenfailmod1.so: \ $(shared-thread-library) $(objpfx)tst-dlopenfaillinkmod.so LDFLAGS-tst-dlopenfaillinkmod.so = -Wl,-soname,tst-dlopenfail-missingmod.so -- 2.47.2