From 61e471762e2a06f385005491761caca13baf35fa Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Thu, 6 Mar 2025 17:25:12 +0100 Subject: [PATCH] ply-device-manager: Update verify_drm_device () comment The comment about why SimpleDRM devices should be skipped is no longer accurate, the kernel does provide rotation info now; and plymouth now has heuristics to guess the device-scale. If SimpleDRM devices should be used or not now mostly is a user preference. Signed-off-by: Hans de Goede --- src/libply-splash-core/ply-device-manager.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/libply-splash-core/ply-device-manager.c b/src/libply-splash-core/ply-device-manager.c index fd54d3a9..7406d5f5 100644 --- a/src/libply-splash-core/ply-device-manager.c +++ b/src/libply-splash-core/ply-device-manager.c @@ -345,18 +345,11 @@ syspath_is_simpledrm (const char *syspath) return ply_string_has_suffix (syspath, "simple-framebuffer.0/drm/card0"); } +/* Only use SimpleDRM devices if requested to do so */ static bool verify_drm_device (ply_device_manager_t *manager, struct udev_device *device) { - /* - * Simple-framebuffer devices driven by simpledrm lack information - * like panel-rotation info and physical size, causing the splash - * to briefly render on its side / without HiDPI scaling, switching - * to the correct rendering when the native driver loads. - * To avoid this treat simpledrm devices as fbdev devices and only - * use them after the timeout. - */ if (!syspath_is_simpledrm (udev_device_get_syspath (device))) return true; /* Not a SimpleDRM device */ -- 2.47.3