From 62bf2777eb978d5c3cb9a3098147b3ef0fcd5a6a Mon Sep 17 00:00:00 2001 From: Michael Tremer Date: Fri, 17 Mar 2023 13:57:33 +0000 Subject: [PATCH] file: Do not check for ELF status again when dumping issues Signed-off-by: Michael Tremer --- src/libpakfire/file.c | 48 +++++++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/src/libpakfire/file.c b/src/libpakfire/file.c index 24a76553..f657d941 100644 --- a/src/libpakfire/file.c +++ b/src/libpakfire/file.c @@ -629,34 +629,32 @@ char* pakfire_file_dump(struct pakfire_file* file, int flags) { goto ERROR; } - if (pakfire_file_matches_class(file, PAKFIRE_FILE_ELF)) { - // Stack-smashing Protection - if (file->issues & PAKFIRE_FILE_NO_SSP) { - r = asprintf(&buffer, "%s [NO-SSP]", buffer); - if (r < 0) - goto ERROR; - } + // Stack-smashing Protection + if (file->issues & PAKFIRE_FILE_NO_SSP) { + r = asprintf(&buffer, "%s [NO-SSP]", buffer); + if (r < 0) + goto ERROR; + } - // Position-independent Executable - if (file->issues & PAKFIRE_FILE_NO_PIE) { - r = asprintf(&buffer, "%s [NO-PIE]", buffer); - if (r < 0) - goto ERROR; - } + // Position-independent Executable + if (file->issues & PAKFIRE_FILE_NO_PIE) { + r = asprintf(&buffer, "%s [NO-PIE]", buffer); + if (r < 0) + goto ERROR; + } - // Executable Stack - if (file->issues & PAKFIRE_FILE_EXECSTACK) { - r = asprintf(&buffer, "%s [EXECSTACK]", buffer); - if (r < 0) - goto ERROR; - } + // Executable Stack + if (file->issues & PAKFIRE_FILE_EXECSTACK) { + r = asprintf(&buffer, "%s [EXECSTACK]", buffer); + if (r < 0) + goto ERROR; + } - // Not Partially RELRO - if (file->issues & PAKFIRE_FILE_NO_PARTIALLY_RELRO) { - r = asprintf(&buffer, "%s [NO-PART-RELRO]", buffer); - if (r < 0) - goto ERROR; - } + // Not Partially RELRO + if (file->issues & PAKFIRE_FILE_NO_PARTIALLY_RELRO) { + r = asprintf(&buffer, "%s [NO-PART-RELRO]", buffer); + if (r < 0) + goto ERROR; } } -- 2.47.3