From 63fed92c96c23e061a64683cab431db1269e3f73 Mon Sep 17 00:00:00 2001 From: Lev Stipakov Date: Thu, 31 Jul 2025 17:29:06 +0200 Subject: [PATCH] Fix wrong byte order of --dns server We already fixed it in commit 82fd89a04f, but the fix got lost in 2dfc4f8. tuntap_options require host byte order, and we store dns servers in struct dns_server in network byte order, what we got from getaddrinfo(). Fix (again) by converting to the host byte order. Change-Id: I37ca672f05e9d77ec586fa28dadc6dc752e574fb Signed-off-by: Lev Stipakov Acked-by: Gert Doering Message-Id: <20250731152912.21826-1-gert@greenie.muc.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32460.html Signed-off-by: Gert Doering --- src/openvpn/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 3ceada0cd..ff9adddd1 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -3573,7 +3573,7 @@ tuntap_options_postprocess_dns(struct options *o) { if (s->addr[i].family == AF_INET && tt->dns_len + 1 < N_DHCP_ADDR) { - tt->dns[tt->dns_len++] = s->addr[i].in.a4.s_addr; + tt->dns[tt->dns_len++] = ntohl(s->addr[i].in.a4.s_addr); } else if (tt->dns6_len + 1 < N_DHCP_ADDR) { -- 2.47.3