From 64034f994c4f176c7a6c9747d8caf86d8df243cd Mon Sep 17 00:00:00 2001 From: =?utf8?q?Martin=20v=2E=20L=C3=B6wis?= Date: Thu, 14 Aug 2008 20:12:06 +0000 Subject: [PATCH] Fix memory leak: Always DECREF obj in PyBuffer_Release. --- Objects/abstract.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Objects/abstract.c b/Objects/abstract.c index aca60bdfcf5f..68e15491b603 100644 --- a/Objects/abstract.c +++ b/Objects/abstract.c @@ -708,11 +708,9 @@ void PyBuffer_Release(Py_buffer *view) { PyObject *obj = view->obj; - if (!obj || !Py_TYPE(obj)->tp_as_buffer || !Py_TYPE(obj)->tp_as_buffer->bf_releasebuffer) - /* Unmanaged buffer */ - return; - Py_TYPE(obj)->tp_as_buffer->bf_releasebuffer(obj, view); - Py_DECREF(obj); + if (obj && Py_TYPE(obj)->tp_as_buffer && Py_TYPE(obj)->tp_as_buffer->bf_releasebuffer) + Py_TYPE(obj)->tp_as_buffer->bf_releasebuffer(obj, view); + Py_XDECREF(obj); view->obj = NULL; } -- 2.47.3