From 651b386205d7578e8de60df0ec3830b315f6686f Mon Sep 17 00:00:00 2001 From: Nicholas Piggin Date: Wed, 28 Aug 2024 14:33:34 +1000 Subject: [PATCH] chardev: Fix record/replay error path NULL deref in device creation MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit qemu_chardev_set_replay() was being called in chardev creation to set up replay parameters even if the chardev is NULL. A segfault can be reproduced by specifying '-serial chardev:bad' with an rr=record mode. Fix this with a NULL pointer check. Reported-by: Peter Maydell Resolves: Coverity CID 1559470 Fixes: 4c193bb129dae ("chardev: set record/replay on the base device of a muxed device") Signed-off-by: Nicholas Piggin Reviewed-by: Marc-André Lureau Reviewed-by: Peter Maydell Message-ID: <20240828043337.14587-2-npiggin@gmail.com> --- chardev/char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char.c b/chardev/char.c index a1722aa076d..1c7f6c711a9 100644 --- a/chardev/char.c +++ b/chardev/char.c @@ -726,7 +726,7 @@ static Chardev *__qemu_chr_new(const char *label, const char *filename, if (strstart(filename, "chardev:", &p)) { chr = qemu_chr_find(p); - if (replay) { + if (replay && chr) { qemu_chardev_set_replay(chr, &err); if (err) { error_report_err(err); -- 2.39.5