From 6551ae9d1a0730ba9896fb95b0bdf87ea74824b1 Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Mon, 31 Jan 2011 18:57:16 -0700 Subject: [PATCH] Bug 3140: memory leak in error page generation Avoid freeing buffer m before using it. Specific to the 3.2+ logics. --- src/errorpage.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/errorpage.cc b/src/errorpage.cc index d4f7ee7bc9..fc92e04565 100644 --- a/src/errorpage.cc +++ b/src/errorpage.cc @@ -1168,11 +1168,12 @@ ErrorState::BuildContent() debugs(4, 2, HERE << "No existing error page language negotiated for " << errorPageName(page_id) << ". Using default error file."); } + MemBuf *result = ConvertText(m, true); #if USE_ERR_LOCALES safe_free(freePage); #endif - return ConvertText(m, true); + return result; } MemBuf *ErrorState::ConvertText(const char *text, bool allowRecursion) -- 2.47.2