From 65e9aa860d06507c9332ec2fdf55d3ca4f2acdc3 Mon Sep 17 00:00:00 2001
From: Petr Machata <pmachata@redhat.com>
Date: Mon, 14 Mar 2011 14:19:59 +0100
Subject: [PATCH] dwarflint: Replace over-zealous assert with a warning

---
 dwarflint/reloc.cc             |   8 ++++++--
 dwarflint/tests/garbage-10.bz2 | Bin 0 -> 596 bytes
 dwarflint/tests/run-bad.sh     |   7 ++++++-
 3 files changed, 12 insertions(+), 3 deletions(-)
 create mode 100644 dwarflint/tests/garbage-10.bz2

diff --git a/dwarflint/reloc.cc b/dwarflint/reloc.cc
index da389d930..d51818eb0 100644
--- a/dwarflint/reloc.cc
+++ b/dwarflint/reloc.cc
@@ -179,7 +179,11 @@ do_one_relocation (elf_file const *file,
   if (file->ehdr.e_type == ET_REL
       && ELF64_ST_TYPE (symbol->st_info) == STT_SECTION)
     {
-      assert (sym_value == 0);
+      if (sym_value != 0)
+	wr_warning (reloc_where)
+	  << "relocation formed using STT_SECTION symbol with non-zero value."
+	  << std::endl;
+
       require_valid_section_index;
       sym_value = file->sec[section_index].shdr.sh_addr;
     }
@@ -200,7 +204,7 @@ do_one_relocation (elf_file const *file,
 	{
 	  if (offset_into != rel_address && section_index == SHN_UNDEF)
 	    wr_error (&reloc_where,
-			": relocation of an address is formed against SHN_UNDEF symbol"
+			": relocation of an address is formed using SHN_UNDEF symbol"
 			" (symtab index %d).\n", rel->symndx);
 	  else
 	    {
diff --git a/dwarflint/tests/garbage-10.bz2 b/dwarflint/tests/garbage-10.bz2
new file mode 100644
index 0000000000000000000000000000000000000000..2afab22f850775da3aaf188ca7f6951559f344df
GIT binary patch
literal 596
zc-jF}0;~N(T4*^jL0KkKS^XY@umA!E|C;~*{!3=(_kY{%62SlO-)Mk95I_JBAPB$#
z>x~+<4Np;1^rOWaP~M}_6HPJ!k%$<8&;S4fYI>NO4NWJa2AYjWq#mGX0D78e41*v8
zK+qZhc|pTNMok(tX`zvj!T`ttkZGU*20+LHM2b%o)Y(nyCL=~8O{f@TCLq8NVrh|}
z$iirP-BOpcw)P{$B#3A0xjo8Eib%3Y>$m+MfMt{H#Wjr(sg-{1>P-9(S4vPpvXV~Z
zRcS3?o=QK6%;3sa2qEVoQ@6}@>v8bTtI(loK({jIa}vOjEts#*0XHToVd_lIu!LP|
zri4;EEEF(VEJ&fDAn1C`8%16i0{-+GEfZ)j*h3b(NFj}Y*qcqKrw9`Y5Q-!r0+Ak9
zV2<piNkn53AS92&4xCH5!PwC>F9Nn&vMc8v3J8=jWmAge6uhy?wv89G!)>bAt<a0k
z<i&?>1QwmUB;;Ik_{IxGJl}~HniUneY#31pE->ye^x!~nvbtcW%?EAW=_FL}DU}kM
zMdFa*R9MD!ieqLSLbcrid)Pw+OpMI)kihebY(VaSux8X3SQce=MJLqSIKh_ALe+zO
zm|q2T@l;`6#fGRCP4Y}{5{MbG-zph-V&yl43-o;p9;j4L{D7Lh<c`w&8TlE&YEZc@
zm<vilKy~psH=hDApsqx%%iu@S>(cAU$+6#s^hQ*umULhf|FgEFGD06}M2<N$@th?E
i1&WDcC`696%%UX#keU^XMK;yL{x0N-aG@dkJq2J<#S<C;

literal 0
Hc-jL100001

diff --git a/dwarflint/tests/run-bad.sh b/dwarflint/tests/run-bad.sh
index 919e098ed..bb2b92e09 100755
--- a/dwarflint/tests/run-bad.sh
+++ b/dwarflint/tests/run-bad.sh
@@ -30,7 +30,7 @@ srcdir=$srcdir/tests
 testfiles hello.bad-1 hello.bad-3 empty-1 \
     garbage-1 garbage-2 garbage-3 garbage-4 \
     garbage-5 garbage-6 garbage-7 garbage-8 \
-    garbage-9
+    garbage-9 garbage-10
 
 testrun_compare ./dwarflint hello.bad-1 <<EOF
 error: .debug_info: DIE 0x83: abbrev section at 0x0 doesn't contain code 83.
@@ -99,3 +99,8 @@ error: .debug_info: DIE 0x84 (abbr. attribute 0x5f): invalid reference outside t
 error: .debug_info: DIE 0x6c: is the last sibling in chain, but has a DW_AT_sibling attribute.
 error: .debug_info: DIE 0xab (abbreviation 113): DIE chain not terminated with null entry.
 EOF
+
+testrun_compare ./dwarflint garbage-10 <<EOF
+warning: .rela.debug_info: offset 0xc: relocation formed using STT_SECTION symbol with non-zero value.
+error: .rela.debug_info: offset 0x11: couldn't obtain symbol #7208969: invalid section index.
+EOF
-- 
2.47.2