From 6611215e3d441a5e6d9d6a2f85c5ea1bf573a8d0 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Sun, 27 Oct 2024 22:11:49 -0700 Subject: [PATCH] xfs: update the pag for the last AG at recovery time Source kernel commit: 4a201dcfa1ff0dcfe4348c40f3ad8bd68b97eb6c Currently log recovery never updates the in-core perag values for the last allocation group when they were grown by growfs. This leads to btree record validation failures for the alloc, ialloc or finotbt trees if a transaction references this new space. Found by Brian's new growfs recovery stress test. Signed-off-by: Christoph Hellwig Reviewed-by: Brian Foster Signed-off-by: Carlos Maiolino --- libxfs/xfs_ag.c | 17 +++++++++++++++++ libxfs/xfs_ag.h | 1 + 2 files changed, 18 insertions(+) diff --git a/libxfs/xfs_ag.c b/libxfs/xfs_ag.c index a22c2be1..79ee483b 100644 --- a/libxfs/xfs_ag.c +++ b/libxfs/xfs_ag.c @@ -271,6 +271,23 @@ xfs_agino_range( return __xfs_agino_range(mp, xfs_ag_block_count(mp, agno), first, last); } +int +xfs_update_last_ag_size( + struct xfs_mount *mp, + xfs_agnumber_t prev_agcount) +{ + struct xfs_perag *pag = xfs_perag_grab(mp, prev_agcount - 1); + + if (!pag) + return -EFSCORRUPTED; + pag->block_count = __xfs_ag_block_count(mp, prev_agcount - 1, + mp->m_sb.sb_agcount, mp->m_sb.sb_dblocks); + __xfs_agino_range(mp, pag->block_count, &pag->agino_min, + &pag->agino_max); + xfs_perag_rele(pag); + return 0; +} + int xfs_initialize_perag( struct xfs_mount *mp, diff --git a/libxfs/xfs_ag.h b/libxfs/xfs_ag.h index 6e68d6a3..9edfe0e9 100644 --- a/libxfs/xfs_ag.h +++ b/libxfs/xfs_ag.h @@ -150,6 +150,7 @@ int xfs_initialize_perag(struct xfs_mount *mp, xfs_agnumber_t old_agcount, void xfs_free_perag_range(struct xfs_mount *mp, xfs_agnumber_t first_agno, xfs_agnumber_t end_agno); int xfs_initialize_perag_data(struct xfs_mount *mp, xfs_agnumber_t agno); +int xfs_update_last_ag_size(struct xfs_mount *mp, xfs_agnumber_t prev_agcount); /* Passive AG references */ struct xfs_perag *xfs_perag_get(struct xfs_mount *mp, xfs_agnumber_t agno); -- 2.47.3