From 6851162adf29762cd121555645214468451a3111 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Mon, 17 Dec 2007 07:43:59 -0500 Subject: [PATCH] clone: correctly report http_fetch errors The exit status from curl was accidentally lost by the 'case' statement. We need to explicitly save it so that $? doesn't get overwritten. This improves the error message when fetching from an http repository which has never had update-server-info run. Previously, it would fail to note the fetch error and produce multiple errors about the lack of origin branches. It now correctly suggests running git-update-server-info. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- git-clone.sh | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/git-clone.sh b/git-clone.sh index 0ea3c24f59..036a37e85c 100755 --- a/git-clone.sh +++ b/git-clone.sh @@ -35,11 +35,12 @@ fi http_fetch () { # $1 = Remote, $2 = Local - curl -nsfL $curl_extra_args "$1" >"$2" || - case $? in - 126|127) exit ;; - *) return $? ;; - esac + curl -nsfL $curl_extra_args "$1" >"$2" + curl_exit_status=$? + case $curl_exit_status in + 126|127) exit ;; + *) return $curl_exit_status ;; + esac } clone_dumb_http () { -- 2.39.2