From 685f3e9c47fc44f7fdaa3622bf941fd4150e4737 Mon Sep 17 00:00:00 2001 From: Alex Rousskov Date: Mon, 26 Feb 2018 17:25:16 -0700 Subject: [PATCH] Fixed a dangerous lie in the dereferenceIdle() description (#163) Also moved private Controller method descriptions to .cc per convention. --- src/store/Controller.cc | 3 +++ src/store/Controller.h | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/store/Controller.cc b/src/store/Controller.cc index 0affe2edb7..bebc65e05c 100644 --- a/src/store/Controller.cc +++ b/src/store/Controller.cc @@ -233,6 +233,7 @@ Store::Controller::callback() return result; } +/// update reference counters of the recently touched entry void Store::Controller::referenceBusy(StoreEntry &e) { @@ -256,6 +257,8 @@ Store::Controller::referenceBusy(StoreEntry &e) } } +/// dereference()s an idle entry +/// \returns false if and only if the entry should be deleted bool Store::Controller::dereferenceIdle(StoreEntry &e, bool wantsLocalMemory) { diff --git a/src/store/Controller.h b/src/store/Controller.h index 1bce65e8f7..3a5290059c 100644 --- a/src/store/Controller.h +++ b/src/store/Controller.h @@ -136,9 +136,7 @@ public: private: bool memoryCacheHasSpaceFor(const int pagesRequired) const; - /// update reference counters of the recently touched entry void referenceBusy(StoreEntry &e); - /// dereference() an idle entry and return true if the entry should be deleted bool dereferenceIdle(StoreEntry &, bool wantsLocalMemory); void allowSharing(StoreEntry &, const cache_key *); -- 2.47.2