From 6d1b9a3b179126ca50e62f4afff5448e2b51ea2e Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Mon, 26 Aug 2024 10:47:10 +0200 Subject: [PATCH] YaHTTP: Fix a non-virtual destructor warning in the `HTTPBase` class MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit `g++` 14.2.1's `-Wnon-virtual-dtor` complains: ``` ‘class YaHTTP::HTTPBase’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] ``` --- ext/yahttp/yahttp/reqresp.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/ext/yahttp/yahttp/reqresp.hpp b/ext/yahttp/yahttp/reqresp.hpp index 4db53bec85..e420c24a15 100644 --- a/ext/yahttp/yahttp/reqresp.hpp +++ b/ext/yahttp/yahttp/reqresp.hpp @@ -98,6 +98,7 @@ namespace YaHTTP { HTTPBase() { HTTPBase::initialize(); }; + virtual ~HTTPBase() = default; virtual void initialize() { kind = 0; -- 2.47.2