From 6d7e29651cf6a2232d66e47974c522cc2927a6c2 Mon Sep 17 00:00:00 2001 From: Vinay Sajip Date: Fri, 6 Sep 2013 10:09:45 +0100 Subject: [PATCH] Issue #18940: Handled low-volume logging when delay is True. --- Lib/logging/handlers.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py index c4b8746ee5a9..8a813d3e375e 100644 --- a/Lib/logging/handlers.py +++ b/Lib/logging/handlers.py @@ -137,7 +137,9 @@ class RotatingFileHandler(BaseRotatingHandler): dfn = self.baseFilename + ".1" if os.path.exists(dfn): os.remove(dfn) - os.rename(self.baseFilename, dfn) + # Issue 18940: A file may not have been created if delay is True. + if os.path.exists(self.baseFilename): + os.rename(self.baseFilename, dfn) #print "%s -> %s" % (self.baseFilename, dfn) self.stream = self._open() @@ -343,7 +345,9 @@ class TimedRotatingFileHandler(BaseRotatingHandler): dfn = self.baseFilename + "." + time.strftime(self.suffix, timeTuple) if os.path.exists(dfn): os.remove(dfn) - os.rename(self.baseFilename, dfn) + # Issue 18940: A file may not have been created if delay is True. + if os.path.exists(self.baseFilename): + os.rename(self.baseFilename, dfn) if self.backupCount > 0: # find the oldest log file and delete it #s = glob.glob(self.baseFilename + ".20*") -- 2.47.3