From 6effc19d9cab54f52ce0a68109542490fb8f6763 Mon Sep 17 00:00:00 2001 From: Bruce Momjian Date: Fri, 12 Aug 2005 02:48:37 +0000 Subject: [PATCH] Document why we only handle trailing "..". --- src/port/path.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/port/path.c b/src/port/path.c index 225ebdf43d0..0890c95aa1a 100644 --- a/src/port/path.c +++ b/src/port/path.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/port/path.c,v 1.52 2005/08/11 03:53:25 momjian Exp $ + * $PostgreSQL: pgsql/src/port/path.c,v 1.53 2005/08/12 02:48:37 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -284,7 +284,13 @@ canonicalize_path(char *path) if (len > 2 && strcmp(path + len - 2, "/.") == 0) trim_directory(path); - /* We can only deal with "/usr/local/..", not "/usr/local/../.." */ + /* + * Process only a single trailing "..", and only if ".." does + * not preceed it. + * So, we only deal with "/usr/local/..", not with "/usr/local/../..". + * We don't handle the even more complex cases, like + * "usr/local/../../.." and "usr/local/../bin/../..". + */ else if (len > 3 && strcmp(path + len - 3, "/..") == 0 && (len != 5 || strcmp(path, "../..") != 0) && (len < 6 || strcmp(path + len - 6, "/../..") != 0)) -- 2.39.5