From 71ef189433f5fb0dec3e5e69bfd6596c194e069c Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Wed, 15 Jan 2014 14:23:14 +1300 Subject: [PATCH] Fix rfcnb library potential NULL pointer dereference Malformed RFCNB packet may lead to crash. Detected by Coverity Scan. Issue 740355. --- lib/rfcnb/rfcnb-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rfcnb/rfcnb-io.c b/lib/rfcnb/rfcnb-io.c index fea3b2829a..f628f1b3f5 100644 --- a/lib/rfcnb/rfcnb-io.c +++ b/lib/rfcnb/rfcnb-io.c @@ -382,7 +382,7 @@ RFCNB_Get_Pkt(struct RFCNB_Con *con, struct RFCNB_Pkt *pkt, int len) offset = RFCNB_Pkt_Hdr_Len; /* Otherwise skip the header */ } - frag_len = pkt_frag->len; + frag_len = (pkt_frag ? pkt_frag->len : 0); if (more <= frag_len) /* If len left to get less than frag space */ this_len = more; /* Get the rest ... */ -- 2.47.2