From 729862401ddbf2554807f085e234e26625ba542c Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Wed, 21 Apr 2010 11:37:52 +0200 Subject: [PATCH] qcow2: Remove abort on free_clusters failure While it's true that during regular operation free_clusters failure would be a bug, an I/O error can always happen. There's no need to kill the VM, the worst thing that can happen (and it will) is that we leak some clusters. Signed-off-by: Kevin Wolf (cherry picked from commit 003fad6e2cae5311d3aea996388c90e3ab17de90) --- block/qcow2-refcount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 465d5d36e8f..ff2cf6db2f6 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -631,7 +631,7 @@ void qcow2_free_clusters(BlockDriverState *bs, ret = update_refcount(bs, offset, size, -1); if (ret < 0) { fprintf(stderr, "qcow2_free_clusters failed: %s\n", strerror(-ret)); - abort(); + /* TODO Remember the clusters to free them later and avoid leaking */ } } -- 2.39.5