From 72f6d4c471131cad31638356dc642698f7c49c2d Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Wed, 29 May 2019 10:03:36 +0200 Subject: [PATCH] auth: Check that we could get the zone info in LMDBBackend::replaceRRSet() Reported by Coverity (CID 1401628). --- modules/lmdbbackend/lmdbbackend.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc index 8f2d0925db..165dcf01e3 100644 --- a/modules/lmdbbackend/lmdbbackend.cc +++ b/modules/lmdbbackend/lmdbbackend.cc @@ -397,8 +397,10 @@ bool LMDBBackend::replaceRRSet(uint32_t domain_id, const DNSName& qname, const Q } DomainInfo di; - d_tdomains->getROTransaction().get(domain_id, di); // XX error checking - + if (!d_tdomains->getROTransaction().get(domain_id, di)) { + return false; + } + compoundOrdername co; auto cursor = txn->txn.getCursor(txn->db->dbi); MDBOutVal key, val; -- 2.47.2