From 73416401fb8e59195239be0004aa2b1b2d897e89 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=BCrg=20Billeter?= Date: Sun, 25 Feb 2007 19:15:33 +0000 Subject: [PATCH] enhance assignment test correct bracketing in compound assignments MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit 2007-02-25 Jürg Billeter * tests/test-010.vala, tests/test-010.out: enhance assignment test * vala/valasemanticanalyzer.vala: correct bracketing in compound assignments svn path=/trunk/; revision=196 --- vala/ChangeLog | 6 ++++++ vala/tests/test-010.out | 2 +- vala/tests/test-010.vala | 8 ++++++-- vala/vala/valasemanticanalyzer.vala | 2 +- 4 files changed, 14 insertions(+), 4 deletions(-) diff --git a/vala/ChangeLog b/vala/ChangeLog index 245de6e94..d03a5fe57 100644 --- a/vala/ChangeLog +++ b/vala/ChangeLog @@ -1,3 +1,9 @@ +2007-02-25 Jürg Billeter + + * tests/test-010.vala, tests/test-010.out: enhance assignment test + * vala/valasemanticanalyzer.vala: correct bracketing in compound + assignments + 2007-02-25 Jürg Billeter * vala/valacodenode.vala: add to_string method diff --git a/vala/tests/test-010.out b/vala/tests/test-010.out index b0fa17f1f..7626fd771 100644 --- a/vala/tests/test-010.out +++ b/vala/tests/test-010.out @@ -1 +1 @@ -Assignment Test: 1 2 3 4 5 6 7 8 9 10 11 12 13 +Assignment Test: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 diff --git a/vala/tests/test-010.vala b/vala/tests/test-010.vala index 6e883be32..c1daa8d7d 100644 --- a/vala/tests/test-010.vala +++ b/vala/tests/test-010.vala @@ -45,8 +45,12 @@ class Maman.Bar { i >>= 1; stdout.printf (" %d", i); - stdout.printf (" 13\n"); - + i = 12; + i -= 1 - 2; + stdout.printf (" %d", i); + + stdout.printf (" 14\n"); + return 0; } } diff --git a/vala/vala/valasemanticanalyzer.vala b/vala/vala/valasemanticanalyzer.vala index ea78ea9dd..e16cc7694 100644 --- a/vala/vala/valasemanticanalyzer.vala +++ b/vala/vala/valasemanticanalyzer.vala @@ -1578,7 +1578,7 @@ public class Vala.SemanticAnalyzer : CodeVisitor { if (!(ma.symbol_reference.node is Signal)) { var old_value = new MemberAccess (ma.inner, ma.member_name); - var bin = new BinaryExpression (BinaryOperator.PLUS, old_value, a.right); + var bin = new BinaryExpression (BinaryOperator.PLUS, old_value, new ParenthesizedExpression (a.right, a.right.source_reference)); if (a.operator == AssignmentOperator.BITWISE_OR) { bin.operator = BinaryOperator.BITWISE_OR; -- 2.47.3