From 73b2b8f827edb0b8ea44be850be0673724eda7b6 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Mon, 23 Nov 2020 09:47:18 +0100 Subject: [PATCH] 4.19-stable patches added patches: alsa-ctl-fix-error-path-at-adding-user-defined-element-set.patch alsa-firewire-clean-up-a-locking-issue-in-copy_resp_to_buf.patch alsa-hda-realtek-add-some-clove-ssid-in-the-alc293-alc1220.patch alsa-mixart-fix-mutex-deadlock.patch alsa-usb-audio-add-delay-quirk-for-all-logitech-usb-devices.patch efivarfs-fix-memory-leak-in-efivarfs_create.patch staging-rtl8723bs-add-024c-0627-to-the-list-of-sdio-device-ids.patch tty-serial-imx-keep-console-clocks-always-on.patch --- ...h-at-adding-user-defined-element-set.patch | 40 +++++++ ...-a-locking-issue-in-copy_resp_to_buf.patch | 50 +++++++++ ...ome-clove-ssid-in-the-alc293-alc1220.patch | 100 ++++++++++++++++++ .../alsa-mixart-fix-mutex-deadlock.patch | 56 ++++++++++ ...y-quirk-for-all-logitech-usb-devices.patch | 45 ++++++++ ...s-fix-memory-leak-in-efivarfs_create.patch | 49 +++++++++ queue-4.19/series | 8 ++ ...-0627-to-the-list-of-sdio-device-ids.patch | 32 ++++++ ...al-imx-keep-console-clocks-always-on.patch | 91 ++++++++++++++++ 9 files changed, 471 insertions(+) create mode 100644 queue-4.19/alsa-ctl-fix-error-path-at-adding-user-defined-element-set.patch create mode 100644 queue-4.19/alsa-firewire-clean-up-a-locking-issue-in-copy_resp_to_buf.patch create mode 100644 queue-4.19/alsa-hda-realtek-add-some-clove-ssid-in-the-alc293-alc1220.patch create mode 100644 queue-4.19/alsa-mixart-fix-mutex-deadlock.patch create mode 100644 queue-4.19/alsa-usb-audio-add-delay-quirk-for-all-logitech-usb-devices.patch create mode 100644 queue-4.19/efivarfs-fix-memory-leak-in-efivarfs_create.patch create mode 100644 queue-4.19/staging-rtl8723bs-add-024c-0627-to-the-list-of-sdio-device-ids.patch create mode 100644 queue-4.19/tty-serial-imx-keep-console-clocks-always-on.patch diff --git a/queue-4.19/alsa-ctl-fix-error-path-at-adding-user-defined-element-set.patch b/queue-4.19/alsa-ctl-fix-error-path-at-adding-user-defined-element-set.patch new file mode 100644 index 00000000000..7afeda07d60 --- /dev/null +++ b/queue-4.19/alsa-ctl-fix-error-path-at-adding-user-defined-element-set.patch @@ -0,0 +1,40 @@ +From 95a793c3bc75cf888e0e641d656e7d080f487d8b Mon Sep 17 00:00:00 2001 +From: Takashi Sakamoto +Date: Fri, 13 Nov 2020 18:20:43 +0900 +Subject: ALSA: ctl: fix error path at adding user-defined element set + +From: Takashi Sakamoto + +commit 95a793c3bc75cf888e0e641d656e7d080f487d8b upstream. + +When processing request to add/replace user-defined element set, check +of given element identifier and decision of numeric identifier is done +in "__snd_ctl_add_replace()" helper function. When the result of check +is wrong, the helper function returns error code. The error code shall +be returned to userspace application. + +Current implementation includes bug to return zero to userspace application +regardless of the result. This commit fixes the bug. + +Cc: +Fixes: e1a7bfe38079 ("ALSA: control: Fix race between adding and removing a user element") +Signed-off-by: Takashi Sakamoto +Link: https://lore.kernel.org/r/20201113092043.16148-1-o-takashi@sakamocchi.jp +Signed-off-by: Takashi Iwai +Signed-off-by: Greg Kroah-Hartman + +--- + sound/core/control.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/sound/core/control.c ++++ b/sound/core/control.c +@@ -1388,7 +1388,7 @@ static int snd_ctl_elem_add(struct snd_c + + unlock: + up_write(&card->controls_rwsem); +- return 0; ++ return err; + } + + static int snd_ctl_elem_add_user(struct snd_ctl_file *file, diff --git a/queue-4.19/alsa-firewire-clean-up-a-locking-issue-in-copy_resp_to_buf.patch b/queue-4.19/alsa-firewire-clean-up-a-locking-issue-in-copy_resp_to_buf.patch new file mode 100644 index 00000000000..8bb2796f011 --- /dev/null +++ b/queue-4.19/alsa-firewire-clean-up-a-locking-issue-in-copy_resp_to_buf.patch @@ -0,0 +1,50 @@ +From 02a9c6ee4183af2e438454c55098b828a96085fb Mon Sep 17 00:00:00 2001 +From: Dan Carpenter +Date: Fri, 13 Nov 2020 13:12:41 +0300 +Subject: ALSA: firewire: Clean up a locking issue in copy_resp_to_buf() + +From: Dan Carpenter + +commit 02a9c6ee4183af2e438454c55098b828a96085fb upstream. + +The spin_lock/unlock_irq() functions cannot be nested. The problem is +that presumably we would want the IRQs to be re-enabled on the second +call the spin_unlock_irq() but instead it will be enabled at the first +call so IRQs will be enabled earlier than expected. + +In this situation the copy_resp_to_buf() function is only called from +one function and it is called with IRQs disabled. We can just use +the regular spin_lock/unlock() functions. + +Fixes: 555e8a8f7f14 ("ALSA: fireworks: Add command/response functionality into hwdep interface") +Signed-off-by: Dan Carpenter +Acked-by: Takashi Sakamoto +Cc: +Link: https://lore.kernel.org/r/20201113101241.GB168908@mwanda +Signed-off-by: Takashi Iwai +Signed-off-by: Greg Kroah-Hartman + +--- + sound/firewire/fireworks/fireworks_transaction.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +--- a/sound/firewire/fireworks/fireworks_transaction.c ++++ b/sound/firewire/fireworks/fireworks_transaction.c +@@ -124,7 +124,7 @@ copy_resp_to_buf(struct snd_efw *efw, vo + t = (struct snd_efw_transaction *)data; + length = min_t(size_t, be32_to_cpu(t->length) * sizeof(u32), length); + +- spin_lock_irq(&efw->lock); ++ spin_lock(&efw->lock); + + if (efw->push_ptr < efw->pull_ptr) + capacity = (unsigned int)(efw->pull_ptr - efw->push_ptr); +@@ -191,7 +191,7 @@ handle_resp_for_user(struct fw_card *car + + copy_resp_to_buf(efw, data, length, rcode); + end: +- spin_unlock_irq(&instances_lock); ++ spin_unlock(&instances_lock); + } + + static void diff --git a/queue-4.19/alsa-hda-realtek-add-some-clove-ssid-in-the-alc293-alc1220.patch b/queue-4.19/alsa-hda-realtek-add-some-clove-ssid-in-the-alc293-alc1220.patch new file mode 100644 index 00000000000..35ed87db87e --- /dev/null +++ b/queue-4.19/alsa-hda-realtek-add-some-clove-ssid-in-the-alc293-alc1220.patch @@ -0,0 +1,100 @@ +From b5acfe152abaa2721c9ca8aa67f941d7de55d24e Mon Sep 17 00:00:00 2001 +From: PeiSen Hou +Date: Wed, 11 Nov 2020 08:58:59 +0100 +Subject: ALSA: hda/realtek: Add some Clove SSID in the ALC293(ALC1220) + +From: PeiSen Hou + +commit b5acfe152abaa2721c9ca8aa67f941d7de55d24e upstream. + +Fix "use as headset mic, without its own jack detect" problem. + +[ Minor coding style fixes by tiwai ] + +Signed-off-by: PeiSen Hou +Cc: +Link: https://lore.kernel.org/r/481963e4a5694ff19f27ae1e283d79ad@realtek.com +Signed-off-by: Takashi Iwai +Signed-off-by: Greg Kroah-Hartman + +--- + sound/pci/hda/patch_realtek.c | 50 +++++++++++++++++++++++++++++++++++++++++- + 1 file changed, 49 insertions(+), 1 deletion(-) + +--- a/sound/pci/hda/patch_realtek.c ++++ b/sound/pci/hda/patch_realtek.c +@@ -2498,13 +2498,23 @@ static const struct snd_pci_quirk alc882 + SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3), + SND_PCI_QUIRK(0x147b, 0x107a, "Abit AW9D-MAX", ALC882_FIXUP_ABIT_AW9D_MAX), + SND_PCI_QUIRK(0x1558, 0x9501, "Clevo P950HR", ALC1220_FIXUP_CLEVO_P950), ++ SND_PCI_QUIRK(0x1558, 0x9506, "Clevo P955HQ", ALC1220_FIXUP_CLEVO_P950), ++ SND_PCI_QUIRK(0x1558, 0x950A, "Clevo P955H[PR]", ALC1220_FIXUP_CLEVO_P950), + SND_PCI_QUIRK(0x1558, 0x95e1, "Clevo P95xER", ALC1220_FIXUP_CLEVO_P950), + SND_PCI_QUIRK(0x1558, 0x95e2, "Clevo P950ER", ALC1220_FIXUP_CLEVO_P950), ++ SND_PCI_QUIRK(0x1558, 0x95e3, "Clevo P955[ER]T", ALC1220_FIXUP_CLEVO_P950), ++ SND_PCI_QUIRK(0x1558, 0x95e4, "Clevo P955ER", ALC1220_FIXUP_CLEVO_P950), ++ SND_PCI_QUIRK(0x1558, 0x95e5, "Clevo P955EE6", ALC1220_FIXUP_CLEVO_P950), ++ SND_PCI_QUIRK(0x1558, 0x95e6, "Clevo P950R[CDF]", ALC1220_FIXUP_CLEVO_P950), + SND_PCI_QUIRK(0x1558, 0x96e1, "Clevo P960[ER][CDFN]-K", ALC1220_FIXUP_CLEVO_P950), + SND_PCI_QUIRK(0x1558, 0x97e1, "Clevo P970[ER][CDFN]", ALC1220_FIXUP_CLEVO_P950), ++ SND_PCI_QUIRK(0x1558, 0x97e2, "Clevo P970RC-M", ALC1220_FIXUP_CLEVO_P950), ++ SND_PCI_QUIRK(0x1558, 0x50d3, "Clevo PC50[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS), + SND_PCI_QUIRK(0x1558, 0x65d1, "Clevo PB51[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS), ++ SND_PCI_QUIRK(0x1558, 0x65d2, "Clevo PB51R[CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS), ++ SND_PCI_QUIRK(0x1558, 0x65e1, "Clevo PB51[ED][DF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS), + SND_PCI_QUIRK(0x1558, 0x67d1, "Clevo PB71[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS), +- SND_PCI_QUIRK(0x1558, 0x50d3, "Clevo PC50[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS), ++ SND_PCI_QUIRK(0x1558, 0x67e1, "Clevo PB71[DE][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS), + SND_PCI_QUIRK(0x1558, 0x70d1, "Clevo PC70[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS), + SND_PCI_QUIRK(0x1558, 0x7714, "Clevo X170", ALC1220_FIXUP_CLEVO_PB51ED_PINS), + SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD), +@@ -7114,11 +7124,49 @@ static const struct snd_pci_quirk alc269 + SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC), ++ SND_PCI_QUIRK(0x1558, 0x1323, "Clevo N130ZU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x1401, "Clevo L140[CZ]U", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x1403, "Clevo N140CU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x1404, "Clevo N150CU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x14a1, "Clevo L141MU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x4018, "Clevo NV40M[BE]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x4019, "Clevo NV40MZ", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x4020, "Clevo NV40MB", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x40a1, "Clevo NL40GU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x40c1, "Clevo NL40[CZ]U", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x40d1, "Clevo NL41DU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x50a3, "Clevo NJ51GU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x50b3, "Clevo NK50S[BEZ]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x50b6, "Clevo NK50S5", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x50b8, "Clevo NK50SZ", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x50d5, "Clevo NP50D5", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x50f0, "Clevo NH50A[CDF]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x50f3, "Clevo NH58DPQ", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x5101, "Clevo S510WU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x5157, "Clevo W517GU1", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x51a1, "Clevo NS50MU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x70a1, "Clevo NB70T[HJK]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x70b3, "Clevo NK70SB", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8228, "Clevo NR40BU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8520, "Clevo NH50D[CD]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8521, "Clevo NH77D[CD]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8535, "Clevo NH50D[BE]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8536, "Clevo NH79D[BE]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x8550, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x8551, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x1558, 0x8561, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC), ++ SND_PCI_QUIRK(0x1558, 0x8668, "Clevo NP50B[BE]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8680, "Clevo NJ50LU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8686, "Clevo NH50[CZ]U", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8a20, "Clevo NH55DCQ-Y", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8a51, "Clevo NH70RCQ-Y", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x8d50, "Clevo NH55RCQ-M", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x951d, "Clevo N950T[CDF]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x961d, "Clevo N960S[CDF]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0x971d, "Clevo N970T[CDF]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), ++ SND_PCI_QUIRK(0x1558, 0xa500, "Clevo NL53RU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS), + SND_PCI_QUIRK(0x17aa, 0x1048, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC), + SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE), diff --git a/queue-4.19/alsa-mixart-fix-mutex-deadlock.patch b/queue-4.19/alsa-mixart-fix-mutex-deadlock.patch new file mode 100644 index 00000000000..cf745b9a3a5 --- /dev/null +++ b/queue-4.19/alsa-mixart-fix-mutex-deadlock.patch @@ -0,0 +1,56 @@ +From d21b96c8ed2aea7e6b7bf4735e1d2503cfbf4072 Mon Sep 17 00:00:00 2001 +From: Takashi Iwai +Date: Thu, 19 Nov 2020 13:14:40 +0100 +Subject: ALSA: mixart: Fix mutex deadlock + +From: Takashi Iwai + +commit d21b96c8ed2aea7e6b7bf4735e1d2503cfbf4072 upstream. + +The code change for switching to non-atomic mode brought the +unexpected mutex deadlock in get_msg(). It converted the spinlock +with the existing mutex, but there were calls with the already holding +the mutex. Since the only place that needs the extra lock is the code +path from snd_mixart_send_msg(), remove the mutex lock in get_msg() +and apply in the caller side for fixing the mutex deadlock. + +Fixes: 8d3a8b5cb57d ("ALSA: mixart: Use nonatomic PCM ops") +Reported-by: Dan Carpenter +Cc: +Link: https://lore.kernel.org/r/20201119121440.18945-1-tiwai@suse.de +Signed-off-by: Takashi Iwai +Signed-off-by: Greg Kroah-Hartman + +--- + sound/pci/mixart/mixart_core.c | 5 ++--- + 1 file changed, 2 insertions(+), 3 deletions(-) + +--- a/sound/pci/mixart/mixart_core.c ++++ b/sound/pci/mixart/mixart_core.c +@@ -83,7 +83,6 @@ static int get_msg(struct mixart_mgr *mg + unsigned int i; + #endif + +- mutex_lock(&mgr->msg_lock); + err = 0; + + /* copy message descriptor from miXart to driver */ +@@ -132,8 +131,6 @@ static int get_msg(struct mixart_mgr *mg + writel_be(headptr, MIXART_MEM(mgr, MSG_OUTBOUND_FREE_HEAD)); + + _clean_exit: +- mutex_unlock(&mgr->msg_lock); +- + return err; + } + +@@ -271,7 +268,9 @@ int snd_mixart_send_msg(struct mixart_mg + resp.data = resp_data; + resp.size = max_resp_size; + ++ mutex_lock(&mgr->msg_lock); + err = get_msg(mgr, &resp, msg_frame); ++ mutex_unlock(&mgr->msg_lock); + + if( request->message_id != resp.message_id ) + dev_err(&mgr->pci->dev, "RESPONSE ERROR!\n"); diff --git a/queue-4.19/alsa-usb-audio-add-delay-quirk-for-all-logitech-usb-devices.patch b/queue-4.19/alsa-usb-audio-add-delay-quirk-for-all-logitech-usb-devices.patch new file mode 100644 index 00000000000..b121c526fd7 --- /dev/null +++ b/queue-4.19/alsa-usb-audio-add-delay-quirk-for-all-logitech-usb-devices.patch @@ -0,0 +1,45 @@ +From 54a2a3898f469a915510038fe84ef4f083131d3e Mon Sep 17 00:00:00 2001 +From: Joakim Tjernlund +Date: Tue, 17 Nov 2020 13:28:03 +0100 +Subject: ALSA: usb-audio: Add delay quirk for all Logitech USB devices + +From: Joakim Tjernlund + +commit 54a2a3898f469a915510038fe84ef4f083131d3e upstream. + +Found one more Logitech device, BCC950 ConferenceCam, which needs +the same delay here. This makes 3 out of 3 devices I have tried. + +Therefore, add a delay for all Logitech devices as it does not hurt. + +Signed-off-by: Joakim Tjernlund +Cc: # 4.19.y, 5.4.y +Link: https://lore.kernel.org/r/20201117122803.24310-1-joakim.tjernlund@infinera.com +Signed-off-by: Takashi Iwai +Signed-off-by: Greg Kroah-Hartman + +--- + sound/usb/quirks.c | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +--- a/sound/usb/quirks.c ++++ b/sound/usb/quirks.c +@@ -1338,13 +1338,13 @@ void snd_usb_ctl_msg_quirk(struct usb_de + && (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS) + msleep(20); + +- /* Zoom R16/24, Logitech H650e/H570e, Jabra 550a, Kingston HyperX +- * needs a tiny delay here, otherwise requests like get/set +- * frequency return as failed despite actually succeeding. ++ /* Zoom R16/24, many Logitech(at least H650e/H570e/BCC950), ++ * Jabra 550a, Kingston HyperX needs a tiny delay here, ++ * otherwise requests like get/set frequency return ++ * as failed despite actually succeeding. + */ + if ((chip->usb_id == USB_ID(0x1686, 0x00dd) || +- chip->usb_id == USB_ID(0x046d, 0x0a46) || +- chip->usb_id == USB_ID(0x046d, 0x0a56) || ++ USB_ID_VENDOR(chip->usb_id) == 0x046d || /* Logitech */ + chip->usb_id == USB_ID(0x0b0e, 0x0349) || + chip->usb_id == USB_ID(0x0951, 0x16ad)) && + (requesttype & USB_TYPE_MASK) == USB_TYPE_CLASS) diff --git a/queue-4.19/efivarfs-fix-memory-leak-in-efivarfs_create.patch b/queue-4.19/efivarfs-fix-memory-leak-in-efivarfs_create.patch new file mode 100644 index 00000000000..df04f894a3d --- /dev/null +++ b/queue-4.19/efivarfs-fix-memory-leak-in-efivarfs_create.patch @@ -0,0 +1,49 @@ +From fe5186cf12e30facfe261e9be6c7904a170bd822 Mon Sep 17 00:00:00 2001 +From: Vamshi K Sthambamkadi +Date: Fri, 23 Oct 2020 17:24:39 +0530 +Subject: efivarfs: fix memory leak in efivarfs_create() + +From: Vamshi K Sthambamkadi + +commit fe5186cf12e30facfe261e9be6c7904a170bd822 upstream. + +kmemleak report: + unreferenced object 0xffff9b8915fcb000 (size 4096): + comm "efivarfs.sh", pid 2360, jiffies 4294920096 (age 48.264s) + hex dump (first 32 bytes): + 2d 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -............... + 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ + backtrace: + [<00000000cc4d897c>] kmem_cache_alloc_trace+0x155/0x4b0 + [<000000007d1dfa72>] efivarfs_create+0x6e/0x1a0 + [<00000000e6ee18fc>] path_openat+0xe4b/0x1120 + [<000000000ad0414f>] do_filp_open+0x91/0x100 + [<00000000ce93a198>] do_sys_openat2+0x20c/0x2d0 + [<000000002a91be6d>] do_sys_open+0x46/0x80 + [<000000000a854999>] __x64_sys_openat+0x20/0x30 + [<00000000c50d89c9>] do_syscall_64+0x38/0x90 + [<00000000cecd6b5f>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 + +In efivarfs_create(), inode->i_private is setup with efivar_entry +object which is never freed. + +Cc: +Signed-off-by: Vamshi K Sthambamkadi +Link: https://lore.kernel.org/r/20201023115429.GA2479@cosmos +Signed-off-by: Ard Biesheuvel +Signed-off-by: Greg Kroah-Hartman + +--- + fs/efivarfs/super.c | 1 + + 1 file changed, 1 insertion(+) + +--- a/fs/efivarfs/super.c ++++ b/fs/efivarfs/super.c +@@ -23,6 +23,7 @@ LIST_HEAD(efivarfs_list); + static void efivarfs_evict_inode(struct inode *inode) + { + clear_inode(inode); ++ kfree(inode->i_private); + } + + static const struct super_operations efivarfs_ops = { diff --git a/queue-4.19/series b/queue-4.19/series index aa67eab201b..e0e4c68cf87 100644 --- a/queue-4.19/series +++ b/queue-4.19/series @@ -64,3 +64,11 @@ xfs-revert-xfs-fix-rmap-key-and-record-comparison-fu.patch efi-x86-free-efi_pgd-with-free_pages.patch libfs-fix-error-cast-of-negative-value-in-simple_att.patch speakup-do-not-let-the-line-discipline-be-used-several-times.patch +alsa-firewire-clean-up-a-locking-issue-in-copy_resp_to_buf.patch +alsa-usb-audio-add-delay-quirk-for-all-logitech-usb-devices.patch +alsa-ctl-fix-error-path-at-adding-user-defined-element-set.patch +alsa-mixart-fix-mutex-deadlock.patch +alsa-hda-realtek-add-some-clove-ssid-in-the-alc293-alc1220.patch +tty-serial-imx-keep-console-clocks-always-on.patch +efivarfs-fix-memory-leak-in-efivarfs_create.patch +staging-rtl8723bs-add-024c-0627-to-the-list-of-sdio-device-ids.patch diff --git a/queue-4.19/staging-rtl8723bs-add-024c-0627-to-the-list-of-sdio-device-ids.patch b/queue-4.19/staging-rtl8723bs-add-024c-0627-to-the-list-of-sdio-device-ids.patch new file mode 100644 index 00000000000..dee06e59e3e --- /dev/null +++ b/queue-4.19/staging-rtl8723bs-add-024c-0627-to-the-list-of-sdio-device-ids.patch @@ -0,0 +1,32 @@ +From aee9dccc5b64e878cf1b18207436e73f66d74157 Mon Sep 17 00:00:00 2001 +From: Brian O'Keefe +Date: Fri, 6 Nov 2020 10:10:34 -0500 +Subject: staging: rtl8723bs: Add 024c:0627 to the list of SDIO device-ids + +From: Brian O'Keefe + +commit aee9dccc5b64e878cf1b18207436e73f66d74157 upstream. + +Add 024c:0627 to the list of SDIO device-ids, based on hardware found in +the wild. This hardware exists on at least some Acer SW1-011 tablets. + +Signed-off-by: Brian O'Keefe +Reviewed-by: Hans de Goede +Link: https://lore.kernel.org/r/b9e1523f-2ba7-fb82-646a-37f095b4440e@alum.wpi.edu +Cc: stable +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 + + 1 file changed, 1 insertion(+) + +--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c ++++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +@@ -20,6 +20,7 @@ static const struct sdio_device_id sdio_ + { SDIO_DEVICE(0x024c, 0x0525), }, + { SDIO_DEVICE(0x024c, 0x0623), }, + { SDIO_DEVICE(0x024c, 0x0626), }, ++ { SDIO_DEVICE(0x024c, 0x0627), }, + { SDIO_DEVICE(0x024c, 0xb723), }, + { /* end: all zeroes */ }, + }; diff --git a/queue-4.19/tty-serial-imx-keep-console-clocks-always-on.patch b/queue-4.19/tty-serial-imx-keep-console-clocks-always-on.patch new file mode 100644 index 00000000000..bc0fb7c3997 --- /dev/null +++ b/queue-4.19/tty-serial-imx-keep-console-clocks-always-on.patch @@ -0,0 +1,91 @@ +From e67c139c488e84e7eae6c333231e791f0e89b3fb Mon Sep 17 00:00:00 2001 +From: Fugang Duan +Date: Wed, 11 Nov 2020 10:51:36 +0800 +Subject: tty: serial: imx: keep console clocks always on +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Fugang Duan + +commit e67c139c488e84e7eae6c333231e791f0e89b3fb upstream. + +For below code, there has chance to cause deadlock in SMP system: +Thread 1: +clk_enable_lock(); +pr_info("debug message"); +clk_enable_unlock(); + +Thread 2: +imx_uart_console_write() + clk_enable() + clk_enable_lock(); + +Thread 1: +Acuired clk enable_lock -> printk -> console_trylock_spinning +Thread 2: +console_unlock() -> imx_uart_console_write -> clk_disable -> Acquite clk enable_lock + +So the patch is to keep console port clocks always on like +other console drivers. + +Fixes: 1cf93e0d5488 ("serial: imx: remove the uart_console() check") +Acked-by: Uwe Kleine-König +Signed-off-by: Fugang Duan +Link: https://lore.kernel.org/r/20201111025136.29818-1-fugang.duan@nxp.com +Cc: stable +[fix up build warning - gregkh] +Signed-off-by: Greg Kroah-Hartman + +--- + drivers/tty/serial/imx.c | 20 +++----------------- + 1 file changed, 3 insertions(+), 17 deletions(-) + +--- a/drivers/tty/serial/imx.c ++++ b/drivers/tty/serial/imx.c +@@ -1915,16 +1915,6 @@ imx_uart_console_write(struct console *c + unsigned int ucr1; + unsigned long flags = 0; + int locked = 1; +- int retval; +- +- retval = clk_enable(sport->clk_per); +- if (retval) +- return; +- retval = clk_enable(sport->clk_ipg); +- if (retval) { +- clk_disable(sport->clk_per); +- return; +- } + + if (sport->port.sysrq) + locked = 0; +@@ -1960,9 +1950,6 @@ imx_uart_console_write(struct console *c + + if (locked) + spin_unlock_irqrestore(&sport->port.lock, flags); +- +- clk_disable(sport->clk_ipg); +- clk_disable(sport->clk_per); + } + + /* +@@ -2063,15 +2050,14 @@ imx_uart_console_setup(struct console *c + + retval = uart_set_options(&sport->port, co, baud, parity, bits, flow); + +- clk_disable(sport->clk_ipg); + if (retval) { +- clk_unprepare(sport->clk_ipg); ++ clk_disable_unprepare(sport->clk_ipg); + goto error_console; + } + +- retval = clk_prepare(sport->clk_per); ++ retval = clk_prepare_enable(sport->clk_per); + if (retval) +- clk_unprepare(sport->clk_ipg); ++ clk_disable_unprepare(sport->clk_ipg); + + error_console: + return retval; -- 2.47.3