From 73f77f38cf8db89b75ce86e0fb09793fea6c3531 Mon Sep 17 00:00:00 2001 From: Ronan Pigott Date: Mon, 8 Apr 2024 12:45:01 -0700 Subject: [PATCH] resolve: really always initialize aux dns_transaction_request_dnssec_rr was already adjusted in 400171036592, to allow for the return parameter to be passed uninitialized. However this codepath was missed, meaning this function could sometimes return success without having actually set the parameter. Fixes: 400171036592 ("resolved: minor dnssec fixups") Fixes: 47690634f157 ("resolved: don't request the SOA for every dns label") --- src/resolve/resolved-dns-transaction.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/resolve/resolved-dns-transaction.c b/src/resolve/resolved-dns-transaction.c index 392f416c98f..dc8b7c8ff0f 100644 --- a/src/resolve/resolved-dns-transaction.c +++ b/src/resolve/resolved-dns-transaction.c @@ -2347,9 +2347,9 @@ static int dns_transaction_request_dnssec_rr_full(DnsTransaction *t, DnsResource r = dns_transaction_go(aux); if (r < 0) return r; - if (ret) - *ret = aux; } + if (ret) + *ret = aux; return 1; } -- 2.39.5