From 747a84b60e672cd7dedfb5f618ddd44770aada8e Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Sun, 25 Oct 2020 20:07:46 +0100 Subject: [PATCH] debuginfod: Translate CURLE_PEER_FAILED_VERIFICATION to ECONNREFUSED. When a file couldn't be retrieved because of an bad HTTPS certificate find-debuginfod currently says: Server query failed: No such file or directory With this patch it will say: Server query failed: Connection refused Signed-off-by: Mark Wielaard --- debuginfod/ChangeLog | 5 +++++ debuginfod/debuginfod-client.c | 1 + doc/ChangeLog | 5 +++++ doc/debuginfod_find_debuginfo.3 | 3 ++- 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog index 3341f1876..558572333 100644 --- a/debuginfod/ChangeLog +++ b/debuginfod/ChangeLog @@ -1,3 +1,8 @@ +2020-10-25 Mark Wielaard + + * debuginfod-client.c (debuginfod_query_server): Translate + CURLE_PEER_FAILED_VERIFICATION to ECONNREFUSED. + 2020-10-20 Frank Ch. Eigler PR26756: more prometheus metrics diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c index 18e7b85f8..0e5177bc6 100644 --- a/debuginfod/debuginfod-client.c +++ b/debuginfod/debuginfod-client.c @@ -871,6 +871,7 @@ debuginfod_query_server (debuginfod_client *c, case CURLE_COULDNT_RESOLVE_HOST: rc = -EHOSTUNREACH; break; // no NXDOMAIN case CURLE_URL_MALFORMAT: rc = -EINVAL; break; case CURLE_COULDNT_CONNECT: rc = -ECONNREFUSED; break; + case CURLE_PEER_FAILED_VERIFICATION: rc = -ECONNREFUSED; break; case CURLE_REMOTE_ACCESS_DENIED: rc = -EACCES; break; case CURLE_WRITE_ERROR: rc = -EIO; break; case CURLE_OUT_OF_MEMORY: rc = -ENOMEM; break; diff --git a/doc/ChangeLog b/doc/ChangeLog index ad17e992e..bde52c115 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,3 +1,8 @@ +2020-10-25 Mark Wielaard + + * debuginfod_find_debuginfo.3 (ECONNREFUSED): Document that this + is also returned for a bad HTTPS server certificate. + 2020-10-07 Frank Ch. Eigler * debuginfod-find.1: Add missing .br for SYNOPSIS section. diff --git a/doc/debuginfod_find_debuginfo.3 b/doc/debuginfod_find_debuginfo.3 index d9717d734..eec04e5ea 100644 --- a/doc/debuginfod_find_debuginfo.3 +++ b/doc/debuginfod_find_debuginfo.3 @@ -254,7 +254,8 @@ Denied access to resource located at the URL. .TP .BR ECONNREFUSED -Unable to connect to remote host. +Unable to connect to remote host. Also returned when an HTTPS connection +couldn't be verified (bad certificate). .TP .BR ECONNRESET -- 2.47.3