From 75430315d2dc704ecd3f3e1f169b0dd1d39e3c11 Mon Sep 17 00:00:00 2001 From: Bodo Graumann Date: Tue, 7 Dec 2021 11:32:46 +0100 Subject: [PATCH] test: await nextTick instead of unmount (#883) --- packages/pinia/__tests__/lifespan.spec.ts | 12 ++++++++---- packages/pinia/__tests__/onAction.spec.ts | 3 ++- packages/pinia/__tests__/store.spec.ts | 3 ++- packages/pinia/__tests__/subscriptions.spec.ts | 3 ++- 4 files changed, 14 insertions(+), 7 deletions(-) diff --git a/packages/pinia/__tests__/lifespan.spec.ts b/packages/pinia/__tests__/lifespan.spec.ts index 8c1c7c2f..e2dcbd3c 100644 --- a/packages/pinia/__tests__/lifespan.spec.ts +++ b/packages/pinia/__tests__/lifespan.spec.ts @@ -91,7 +91,8 @@ describe('Store Lifespan', () => { let wrapper = mount(Component, options) await nextTick() - await wrapper.unmount() + wrapper.unmount() + await nextTick() expect(inComponentWatch).toHaveBeenCalledTimes(1) @@ -102,7 +103,8 @@ describe('Store Lifespan', () => { wrapper = mount(Component, options) await nextTick() - await wrapper.unmount() + wrapper.unmount() + await nextTick() expect(inComponentWatch).toHaveBeenCalledTimes(2) @@ -142,7 +144,8 @@ describe('Store Lifespan', () => { } let wrapper = mount(Component, options) - await wrapper.unmount() + wrapper.unmount() + await nextTick() expect(globalWatch).toHaveBeenCalledTimes(1) @@ -152,7 +155,8 @@ describe('Store Lifespan', () => { expect(globalWatch).toHaveBeenCalledTimes(2) wrapper = mount(Component, options) - await wrapper.unmount() + wrapper.unmount() + await nextTick() expect(globalWatch).toHaveBeenCalledTimes(3) diff --git a/packages/pinia/__tests__/onAction.spec.ts b/packages/pinia/__tests__/onAction.spec.ts index a90a09d0..7d054303 100644 --- a/packages/pinia/__tests__/onAction.spec.ts +++ b/packages/pinia/__tests__/onAction.spec.ts @@ -197,7 +197,8 @@ describe('Subscriptions', () => { expect(spy1).toHaveBeenCalledTimes(2) expect(spy2).toHaveBeenCalledTimes(2) - await wrapper.unmount() + wrapper.unmount() + await nextTick() s1.changeName('again') expect(spy1).toHaveBeenCalledTimes(2) diff --git a/packages/pinia/__tests__/store.spec.ts b/packages/pinia/__tests__/store.spec.ts index c7df724d..cf90e68f 100644 --- a/packages/pinia/__tests__/store.spec.ts +++ b/packages/pinia/__tests__/store.spec.ts @@ -212,7 +212,8 @@ describe('Store', () => { expect(spy).toHaveBeenCalledTimes(1) expect(wrapper.html()).toBe('n: 1') - await wrapper.unmount() + wrapper.unmount() + await nextTick() store.n++ await nextTick() expect(spy).toHaveBeenCalledTimes(2) diff --git a/packages/pinia/__tests__/subscriptions.spec.ts b/packages/pinia/__tests__/subscriptions.spec.ts index 2fef5252..82fb25a6 100644 --- a/packages/pinia/__tests__/subscriptions.spec.ts +++ b/packages/pinia/__tests__/subscriptions.spec.ts @@ -132,7 +132,8 @@ describe('Subscriptions', () => { expect(spy1).toHaveBeenCalledTimes(2) expect(spy2).toHaveBeenCalledTimes(2) - await wrapper.unmount() + wrapper.unmount() + await nextTick() s1.$patch({ name: 'b' }) expect(spy1).toHaveBeenCalledTimes(2) -- 2.47.3