From 76bce32bcd539bd76bacace67a2d2e33b2c570d3 Mon Sep 17 00:00:00 2001 From: Sasha Levin Date: Fri, 25 Jun 2021 07:56:14 -0400 Subject: [PATCH] Fixes for 5.10 Signed-off-by: Sasha Levin --- ...-not-read-power-state-in-pci_enable_.patch | 57 +++++++++++++++++++ queue-5.10/series | 2 + ...-move-the-register-operation-after-t.patch | 53 +++++++++++++++++ 3 files changed, 112 insertions(+) create mode 100644 queue-5.10/revert-pci-pm-do-not-read-power-state-in-pci_enable_.patch create mode 100644 queue-5.10/spi-spi-nxp-fspi-move-the-register-operation-after-t.patch diff --git a/queue-5.10/revert-pci-pm-do-not-read-power-state-in-pci_enable_.patch b/queue-5.10/revert-pci-pm-do-not-read-power-state-in-pci_enable_.patch new file mode 100644 index 00000000000..bad81f15d69 --- /dev/null +++ b/queue-5.10/revert-pci-pm-do-not-read-power-state-in-pci_enable_.patch @@ -0,0 +1,57 @@ +From fc30aa663aeeccae50f7b94a077a9811bd0ccf6f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 22 Jun 2021 17:35:18 +0200 +Subject: Revert "PCI: PM: Do not read power state in + pci_enable_device_flags()" + +From: Rafael J. Wysocki + +[ Upstream commit 4d6035f9bf4ea12776322746a216e856dfe46698 ] + +Revert commit 4514d991d992 ("PCI: PM: Do not read power state in +pci_enable_device_flags()") that is reported to cause PCI device +initialization issues on some systems. + +BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=213481 +Link: https://lore.kernel.org/linux-acpi/YNDoGICcg0V8HhpQ@eldamar.lan +Reported-by: Michael +Reported-by: Salvatore Bonaccorso +Fixes: 4514d991d992 ("PCI: PM: Do not read power state in pci_enable_device_flags()") +Signed-off-by: Rafael J. Wysocki +Signed-off-by: Sasha Levin +--- + drivers/pci/pci.c | 16 +++++++++++++--- + 1 file changed, 13 insertions(+), 3 deletions(-) + +diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c +index d5d9ea864fe6..9e971fffeb6a 100644 +--- a/drivers/pci/pci.c ++++ b/drivers/pci/pci.c +@@ -1874,11 +1874,21 @@ static int pci_enable_device_flags(struct pci_dev *dev, unsigned long flags) + int err; + int i, bars = 0; + +- if (atomic_inc_return(&dev->enable_cnt) > 1) { +- pci_update_current_state(dev, dev->current_state); +- return 0; /* already enabled */ ++ /* ++ * Power state could be unknown at this point, either due to a fresh ++ * boot or a device removal call. So get the current power state ++ * so that things like MSI message writing will behave as expected ++ * (e.g. if the device really is in D0 at enable time). ++ */ ++ if (dev->pm_cap) { ++ u16 pmcsr; ++ pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr); ++ dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK); + } + ++ if (atomic_inc_return(&dev->enable_cnt) > 1) ++ return 0; /* already enabled */ ++ + bridge = pci_upstream_bridge(dev); + if (bridge) + pci_enable_bridge(bridge); +-- +2.30.2 + diff --git a/queue-5.10/series b/queue-5.10/series index 39d402c8fef..ddee0e90979 100644 --- a/queue-5.10/series +++ b/queue-5.10/series @@ -10,3 +10,5 @@ mmc-meson-gx-use-memcpy_to-fromio-for-dram-access-quirk.patch mips-generic-update-node-names-to-avoid-unit-addresses.patch arm64-ignore-any-dma-offsets-in-the-max_zone_phys-calculation.patch arm64-force-no_block_mappings-if-crashkernel-reservation-is-required.patch +spi-spi-nxp-fspi-move-the-register-operation-after-t.patch +revert-pci-pm-do-not-read-power-state-in-pci_enable_.patch diff --git a/queue-5.10/spi-spi-nxp-fspi-move-the-register-operation-after-t.patch b/queue-5.10/spi-spi-nxp-fspi-move-the-register-operation-after-t.patch new file mode 100644 index 00000000000..9c5aed4ff9a --- /dev/null +++ b/queue-5.10/spi-spi-nxp-fspi-move-the-register-operation-after-t.patch @@ -0,0 +1,53 @@ +From 3321c0abaa8f5a875c73c892729b8b87c21f7849 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 10 Jun 2021 17:24:33 +0800 +Subject: spi: spi-nxp-fspi: move the register operation after the clock enable + +From: Haibo Chen + +[ Upstream commit f422316c8e9d3c4aff3c56549dfb44a677d02f14 ] + +Move the register operation after the clock enable, otherwise system +will stuck when this driver probe. + +Fixes: 71d80563b076 ("spi: spi-nxp-fspi: fix fspi panic by unexpected interrupts") +Signed-off-by: Haibo Chen +Link: https://lore.kernel.org/r/1623317073-25158-1-git-send-email-haibo.chen@nxp.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-nxp-fspi.c | 11 +++++------ + 1 file changed, 5 insertions(+), 6 deletions(-) + +diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c +index ab9035662717..bcc0b5a3a459 100644 +--- a/drivers/spi/spi-nxp-fspi.c ++++ b/drivers/spi/spi-nxp-fspi.c +@@ -1033,12 +1033,6 @@ static int nxp_fspi_probe(struct platform_device *pdev) + goto err_put_ctrl; + } + +- /* Clear potential interrupts */ +- reg = fspi_readl(f, f->iobase + FSPI_INTR); +- if (reg) +- fspi_writel(f, reg, f->iobase + FSPI_INTR); +- +- + /* find the resources - controller memory mapped space */ + if (is_acpi_node(f->dev->fwnode)) + res = platform_get_resource(pdev, IORESOURCE_MEM, 1); +@@ -1076,6 +1070,11 @@ static int nxp_fspi_probe(struct platform_device *pdev) + } + } + ++ /* Clear potential interrupts */ ++ reg = fspi_readl(f, f->iobase + FSPI_INTR); ++ if (reg) ++ fspi_writel(f, reg, f->iobase + FSPI_INTR); ++ + /* find the irq */ + ret = platform_get_irq(pdev, 0); + if (ret < 0) +-- +2.30.2 + -- 2.47.2