From 774e3447162735e3a5ba6ada724c3174dd44f496 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Mon, 10 Mar 2025 13:48:34 +0300 Subject: [PATCH] pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all() The next line checks if this regmap_write() failed, but it doesn't work because the assignment was accidentally left out. Add the assignment. Fixes: 60d69769c851 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux") Signed-off-by: Dan Carpenter Acked-by: Artur Weber Reviewed-by: Florian Fainelli Link: https://lore.kernel.org/dfc15d59-7fa9-4f96-aacb-37c3df6d420d@stanley.mountain Signed-off-by: Linus Walleij --- drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm281xx.c b/drivers/pinctrl/bcm/pinctrl-bcm281xx.c index 7c8f8bd7da129..9ea20fde3a242 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm281xx.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm281xx.c @@ -1498,8 +1498,8 @@ static int bcm21664_pinctrl_lock_all(struct bcm281xx_pinctrl_data *pdata) rc); return rc; } - regmap_write(pdata->regmap, BCM21664_ACCESS_LOCK_OFFSET(i), - 0xffffffff); + rc = regmap_write(pdata->regmap, BCM21664_ACCESS_LOCK_OFFSET(i), + 0xffffffff); if (rc) { dev_err(pdata->dev, "Failed to write access lock: %d\n", rc); -- 2.47.2