From 7a787eb530f1f8ba4fb417a9bacff0090b172314 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Fri, 25 Jul 2025 12:05:12 +0200 Subject: [PATCH] dnsdist: Fix CodeQL warnings Signed-off-by: Remi Gacogne --- pdns/dnsdistdist/dnsdist-lbpolicies.cc | 6 +++--- pdns/dnsdistdist/dnsdist-lua.cc | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pdns/dnsdistdist/dnsdist-lbpolicies.cc b/pdns/dnsdistdist/dnsdist-lbpolicies.cc index 4cdc57b023..56c6fcda20 100644 --- a/pdns/dnsdistdist/dnsdist-lbpolicies.cc +++ b/pdns/dnsdistdist/dnsdist-lbpolicies.cc @@ -345,7 +345,7 @@ void setPoolPolicy(const string& poolName, std::shared_ptr policy) } dnsdist::configuration::updateRuntimeConfiguration([&poolName, &policy](dnsdist::configuration::RuntimeConfiguration& config) { - auto [poolIt, inserted] = config.d_pools.emplace(poolName, ServerPool()); + auto [poolIt, _] = config.d_pools.emplace(poolName, ServerPool()); poolIt->second.policy = std::move(policy); }); } @@ -359,7 +359,7 @@ void addServerToPool(const string& poolName, std::shared_ptr se } dnsdist::configuration::updateRuntimeConfiguration([&poolName, &server](dnsdist::configuration::RuntimeConfiguration& config) { - auto [poolIt, inserted] = config.d_pools.emplace(poolName, ServerPool()); + auto [poolIt, _] = config.d_pools.emplace(poolName, ServerPool()); poolIt->second.addServer(server); }); } @@ -374,7 +374,7 @@ void removeServerFromPool(const string& poolName, std::shared_ptrsecond.removeServer(server); }); } diff --git a/pdns/dnsdistdist/dnsdist-lua.cc b/pdns/dnsdistdist/dnsdist-lua.cc index f84fc4af61..422dcf4032 100644 --- a/pdns/dnsdistdist/dnsdist-lua.cc +++ b/pdns/dnsdistdist/dnsdist-lua.cc @@ -1682,7 +1682,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck) } bool created = false; dnsdist::configuration::updateRuntimeConfiguration([&poolName, &created](dnsdist::configuration::RuntimeConfiguration& config) { - auto [poolIt, inserted] = config.d_pools.emplace(poolName, ServerPool()); + auto [_, inserted] = config.d_pools.emplace(poolName, ServerPool()); created = inserted; }); -- 2.47.3