From 7bdfb48c3f2c1084f2a7112e039bc0ca0d42c1c1 Mon Sep 17 00:00:00 2001 From: Manos Pitsidianakis Date: Tue, 25 Jun 2024 15:26:51 +0300 Subject: [PATCH] imap: use spec compliant continuation request cmd_authenticate() replies to AUTHENTICATE commands with "+" CRLF but the imap4rev1 RFC [^0] defines the following ABNF syntax for a continuation request: continue-req = "+" SP (resp-text / base64) CRLF A space (SP) is required before CRLF. [0]: https://www.rfc-editor.org/rfc/rfc3501#page-84 Signed-off-by: Manos Pitsidianakis --- lib/PublicInbox/IMAP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm index 0eb21b6a2..378a0363e 100644 --- a/lib/PublicInbox/IMAP.pm +++ b/lib/PublicInbox/IMAP.pm @@ -158,7 +158,7 @@ sub cmd_logout ($$) { sub cmd_authenticate ($$$) { my ($self, $tag) = @_; # $method = $_[2], should be "ANONYMOUS" $self->{-login_tag} = $tag; - "+\r\n"; # challenge + "+ \r\n"; # challenge } sub cmd_capability ($$) { -- 2.47.3