From 7e77597d71aab419ff8e9bba788be4051606aecb Mon Sep 17 00:00:00 2001 From: Eugene Syromiatnikov Date: Mon, 15 Sep 2025 04:05:04 +0200 Subject: [PATCH] test/wpackettest.c: remove bogus cleanup() in test_WPACKET_quic_vlint_random() In the beginning of the iteration, pkt is not initialised yet, so there is no need to clean it up on RAND_bytes() failure. Replace "return cleanup(&pkt)" with plain "return 0". Fixes: 416d0a638c16 "QUIC wire format support" Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1665422 References: https://github.com/openssl/project/issues/1432 Signed-off-by: Eugene Syromiatnikov Reviewed-by: Paul Dale Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/28647) (cherry picked from commit 732a0a5df8324240e115d599c79487844d64efec) --- test/wpackettest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/wpackettest.c b/test/wpackettest.c index bd696e00740..c6d6faf5c48 100644 --- a/test/wpackettest.c +++ b/test/wpackettest.c @@ -588,7 +588,7 @@ static int test_WPACKET_quic_vlint_random(void) for (i = 0; i < 10000; ++i) { if (!TEST_int_gt(RAND_bytes(rand_data, sizeof(rand_data)), 0)) - return cleanup(&pkt); + return 0; memcpy(&expected, rand_data, sizeof(expected)); -- 2.47.3