From 804ce2ed3c7865cd4e4ba9f0c82d2779c59dbe4e Mon Sep 17 00:00:00 2001 From: Thomas Winter Date: Thu, 24 Jul 2025 11:58:31 +1200 Subject: [PATCH] decode/pppoe: CDPCP as a known protocol Cisco Discovery Protocol Control Protocol may be sent over pppoe. We should allow it to help network functions. --- src/decode-ppp.c | 1 + src/decode-ppp.h | 1 + src/decode-pppoe.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/decode-ppp.c b/src/decode-ppp.c index 7d502e290e..8820e1121a 100644 --- a/src/decode-ppp.c +++ b/src/decode-ppp.c @@ -138,6 +138,7 @@ static int DecodePPPUncompressedProto(ThreadVars *tv, DecodeThreadVars *dtv, Pac case PPP_LQM: case PPP_CBCP: case PPP_COMP_DGRAM: + case PPP_CDPCP: /* Valid types to be in PPP but don't inspect validity. */ return TM_ECODE_OK; diff --git a/src/decode-ppp.h b/src/decode-ppp.h index a5ed9766d5..caefd41323 100644 --- a/src/decode-ppp.h +++ b/src/decode-ppp.h @@ -54,6 +54,7 @@ #define PPP_STIICP 0x8033 /* Stream Protocol Control Protocol */ #define PPP_VINESCP 0x8035 /* Banyan Vines Control Protocol */ #define PPP_IPV6CP 0x8057 /* IPv6 Control Protocol */ +#define PPP_CDPCP 0x8207 /* Cisco Discovery Protocol Control Protocol */ #define PPP_MPLSCP 0x8281 /* rfc 3022 */ #define PPP_LCP 0xc021 /* Link Control Protocol */ #define PPP_PAP 0xc023 /* Password Authentication Protocol */ diff --git a/src/decode-pppoe.c b/src/decode-pppoe.c index bf13887846..d5998f9d81 100644 --- a/src/decode-pppoe.c +++ b/src/decode-pppoe.c @@ -199,6 +199,7 @@ int DecodePPPOESession( case PPP_LQM: case PPP_CBCP: case PPP_COMP_DGRAM: + case PPP_CDPCP: /* Valid types to be in PPP but don't inspect validity. */ break; -- 2.47.3