From 8483a54b7da709c6f381f2dd06085a67ecf669ba Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Thu, 19 Oct 2023 11:31:05 -0400 Subject: [PATCH] Doc: modernize comment for boolin(). Most of the behavior described by this comment was moved to parse_bool_with_len() some time ago. Move what's still valuable there too, and drop the rest. Peter Smith Discussion: https://postgr.es/m/CAHut+PtMJURKp=U8Z=Ktp0zV40sEb1f-iEk9FvY2GQe+5ZBnwg@mail.gmail.com --- src/backend/utils/adt/bool.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/backend/utils/adt/bool.c b/src/backend/utils/adt/bool.c index cc4bd550354..16ae96a8ff4 100644 --- a/src/backend/utils/adt/bool.c +++ b/src/backend/utils/adt/bool.c @@ -35,6 +35,7 @@ parse_bool(const char *value, bool *result) bool parse_bool_with_len(const char *value, size_t len, bool *result) { + /* Check the most-used possibilities first. */ switch (*value) { case 't': @@ -119,12 +120,7 @@ parse_bool_with_len(const char *value, size_t len, bool *result) *****************************************************************************/ /* - * boolin - converts "t" or "f" to 1 or 0 - * - * Check explicitly for "true/false" and TRUE/FALSE, 1/0, YES/NO, ON/OFF. - * Reject other values. - * - * In the switch statement, check the most-used possibilities first. + * boolin - input function for type boolean */ Datum boolin(PG_FUNCTION_ARGS) -- 2.39.5