From 856172e8a97cc77aeb6ea2efdacddc73d8bd3cab Mon Sep 17 00:00:00 2001 From: Sasha Levin Date: Mon, 29 Apr 2024 09:38:17 -0400 Subject: [PATCH] Fixes for 5.4 Signed-off-by: Sasha Levin --- ...ne-owl-fix-register-access-functions.patch | 58 +++++++++++++++++ ...ix-null-function-pointer-dereference.patch | 64 +++++++++++++++++++ ...-to-serve-interrupts-when-device-is-.patch | 44 +++++++++++++ queue-5.4/series | 3 + 4 files changed, 169 insertions(+) create mode 100644 queue-5.4/dmaengine-owl-fix-register-access-functions.patch create mode 100644 queue-5.4/i2c-smbus-fix-null-function-pointer-dereference.patch create mode 100644 queue-5.4/idma64-don-t-try-to-serve-interrupts-when-device-is-.patch diff --git a/queue-5.4/dmaengine-owl-fix-register-access-functions.patch b/queue-5.4/dmaengine-owl-fix-register-access-functions.patch new file mode 100644 index 00000000000..99cc73022fb --- /dev/null +++ b/queue-5.4/dmaengine-owl-fix-register-access-functions.patch @@ -0,0 +1,58 @@ +From b8186b7f7bc5f2a932ac269545140ddf9c9340fb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 22 Mar 2024 14:21:07 +0100 +Subject: dmaengine: owl: fix register access functions + +From: Arnd Bergmann + +[ Upstream commit 43c633ef93a5d293c96ebcedb40130df13128428 ] + +When building with 'make W=1', clang notices that the computed register +values are never actually written back but instead the wrong variable +is set: + +drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] + 244 | u32 regval; + | ^ +drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] + 268 | u32 regval; + | ^ + +Change these to what was most likely intended. + +Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver") +Signed-off-by: Arnd Bergmann +Reviewed-by: Peter Korsgaard +Reviewed-by: Manivannan Sadhasivam +Link: https://lore.kernel.org/r/20240322132116.906475-1-arnd@kernel.org +Signed-off-by: Vinod Koul +Signed-off-by: Sasha Levin +--- + drivers/dma/owl-dma.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/drivers/dma/owl-dma.c b/drivers/dma/owl-dma.c +index bb9c361e224bc..3e4ade21cf413 100644 +--- a/drivers/dma/owl-dma.c ++++ b/drivers/dma/owl-dma.c +@@ -238,7 +238,7 @@ static void pchan_update(struct owl_dma_pchan *pchan, u32 reg, + else + regval &= ~val; + +- writel(val, pchan->base + reg); ++ writel(regval, pchan->base + reg); + } + + static void pchan_writel(struct owl_dma_pchan *pchan, u32 reg, u32 data) +@@ -262,7 +262,7 @@ static void dma_update(struct owl_dma *od, u32 reg, u32 val, bool state) + else + regval &= ~val; + +- writel(val, od->base + reg); ++ writel(regval, od->base + reg); + } + + static void dma_writel(struct owl_dma *od, u32 reg, u32 data) +-- +2.43.0 + diff --git a/queue-5.4/i2c-smbus-fix-null-function-pointer-dereference.patch b/queue-5.4/i2c-smbus-fix-null-function-pointer-dereference.patch new file mode 100644 index 00000000000..89f3e04e0bb --- /dev/null +++ b/queue-5.4/i2c-smbus-fix-null-function-pointer-dereference.patch @@ -0,0 +1,64 @@ +From 31a8db6282c3cabd806a2e0b79b676473be76559 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 26 Apr 2024 08:44:08 +0200 +Subject: i2c: smbus: fix NULL function pointer dereference + +From: Wolfram Sang + +[ Upstream commit 91811a31b68d3765b3065f4bb6d7d6d84a7cfc9f ] + +Baruch reported an OOPS when using the designware controller as target +only. Target-only modes break the assumption of one transfer function +always being available. Fix this by always checking the pointer in +__i2c_transfer. + +Reported-by: Baruch Siach +Closes: https://lore.kernel.org/r/4269631780e5ba789cf1ae391eec1b959def7d99.1712761976.git.baruch@tkos.co.il +Fixes: 4b1acc43331d ("i2c: core changes for slave support") +[wsa: dropped the simplification in core-smbus to avoid theoretical regressions] +Signed-off-by: Wolfram Sang +Tested-by: Baruch Siach +Signed-off-by: Sasha Levin +--- + drivers/i2c/i2c-core-base.c | 12 ++++++------ + 1 file changed, 6 insertions(+), 6 deletions(-) + +diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c +index 964e8a29b27b4..cf9ad03bb34de 100644 +--- a/drivers/i2c/i2c-core-base.c ++++ b/drivers/i2c/i2c-core-base.c +@@ -1965,13 +1965,18 @@ static int i2c_check_for_quirks(struct i2c_adapter *adap, struct i2c_msg *msgs, + * Returns negative errno, else the number of messages executed. + * + * Adapter lock must be held when calling this function. No debug logging +- * takes place. adap->algo->master_xfer existence isn't checked. ++ * takes place. + */ + int __i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) + { + unsigned long orig_jiffies; + int ret, try; + ++ if (!adap->algo->master_xfer) { ++ dev_dbg(&adap->dev, "I2C level transfers not supported\n"); ++ return -EOPNOTSUPP; ++ } ++ + if (WARN_ON(!msgs || num < 1)) + return -EINVAL; + +@@ -2038,11 +2043,6 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) + { + int ret; + +- if (!adap->algo->master_xfer) { +- dev_dbg(&adap->dev, "I2C level transfers not supported\n"); +- return -EOPNOTSUPP; +- } +- + /* REVISIT the fault reporting model here is weak: + * + * - When we get an error after receiving N bytes from a slave, +-- +2.43.0 + diff --git a/queue-5.4/idma64-don-t-try-to-serve-interrupts-when-device-is-.patch b/queue-5.4/idma64-don-t-try-to-serve-interrupts-when-device-is-.patch new file mode 100644 index 00000000000..4cb9f3a2f17 --- /dev/null +++ b/queue-5.4/idma64-don-t-try-to-serve-interrupts-when-device-is-.patch @@ -0,0 +1,44 @@ +From ac99ca60c8f40f1540fe663625042a2046141e6a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 21 Mar 2024 14:04:21 +0200 +Subject: idma64: Don't try to serve interrupts when device is powered off + +From: Andy Shevchenko + +[ Upstream commit 9140ce47872bfd89fca888c2f992faa51d20c2bc ] + +When iDMA 64-bit device is powered off, the IRQ status register +is all 1:s. This is never happen in real case and signalling that +the device is simply powered off. Don't try to serve interrupts +that are not ours. + +Fixes: 667dfed98615 ("dmaengine: add a driver for Intel integrated DMA 64-bit") +Reported-by: Heiner Kallweit +Closes: https://lore.kernel.org/r/700bbb84-90e1-4505-8ff0-3f17ea8bc631@gmail.com +Tested-by: Heiner Kallweit +Signed-off-by: Andy Shevchenko +Link: https://lore.kernel.org/r/20240321120453.1360138-1-andriy.shevchenko@linux.intel.com +Signed-off-by: Vinod Koul +Signed-off-by: Sasha Levin +--- + drivers/dma/idma64.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c +index f5a84c8463945..db506e1f7ef4e 100644 +--- a/drivers/dma/idma64.c ++++ b/drivers/dma/idma64.c +@@ -167,6 +167,10 @@ static irqreturn_t idma64_irq(int irq, void *dev) + u32 status_err; + unsigned short i; + ++ /* Since IRQ may be shared, check if DMA controller is powered on */ ++ if (status == GENMASK(31, 0)) ++ return IRQ_NONE; ++ + dev_vdbg(idma64->dma.dev, "%s: status=%#x\n", __func__, status); + + /* Check if we have any interrupt from the DMA controller */ +-- +2.43.0 + diff --git a/queue-5.4/series b/queue-5.4/series index 1515afbe6d3..08d019042ac 100644 --- a/queue-5.4/series +++ b/queue-5.4/series @@ -97,3 +97,6 @@ stackdepot-respect-__gfp_nolockdep-allocation-flag.patch mtd-diskonchip-work-around-ubsan-link-failure.patch tcp-clean-up-kernel-listener-s-reqsk-in-inet_twsk_purge.patch tcp-fix-new_syn_recv-handling-in-inet_twsk_purge.patch +dmaengine-owl-fix-register-access-functions.patch +idma64-don-t-try-to-serve-interrupts-when-device-is-.patch +i2c-smbus-fix-null-function-pointer-dereference.patch -- 2.47.2